Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compile failure on windows #19

Open
carllerche opened this issue Jan 21, 2020 · 2 comments
Open

Compile failure on windows #19

carllerche opened this issue Jan 21, 2020 · 2 comments

Comments

@carllerche
Copy link

For some reason, generator is starting to fail to compile on windows. This started recently on the Azure windows CI platform. Here is an example of a failed build:

https://dev.azure.com/tokio-rs/Tokio/_build/results?buildId=4652&view=logs&jobId=edbb8bb1-bc6c-5b89-6b1a-b043f7e49efc&j=edbb8bb1-bc6c-5b89-6b1a-b043f7e49efc&t=38b5b02f-30ce-5594-6cc9-d7432c882ad9

The error is:

error: failed to run custom build command for `generator v0.6.19`

Caused by:
  process didn't exit successfully: `D:\a\1\s\target\debug\build\generator-7edb320b2034b9ab\build-script-build` (exit code: 1)
--- stdout
TARGET = Some("i686-pc-windows-msvc")
running: "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Enterprise\\VC\\Tools\\MSVC\\14.16.27023\\bin\\HostX64\\x86\\ml.exe" "-safeseh" "-FoD:\\a\\1\\s\\target\\debug\\build\\generator-cb101e03a46c8720\\out\\src/detail/asm\\asm_i386_ms_pe_masm.o" "-c" "src/detail/asm\\asm_i386_ms_pe_masm.asm"
cargo:warning=Microsoft (R) Macro Assembler Version 14.16.27034.0
cargo:warning=Copyright (C) Microsoft Corporation.  All rights reserved.
cargo:warning=
 Assembling: src/detail/asm\asm_i386_ms_pe_masm.asm
MASM : fatal error A1000:cannot open file : src/detail/asm\asm_i386_ms_pe_masm.asm
exit code: 1

--- stderr


error occurred: Command "C:\\Program Files (x86)\\Microsoft Visual Studio\\2017\\Enterprise\\VC\\Tools\\MSVC\\14.16.27023\\bin\\HostX64\\x86\\ml.exe" "-safeseh" "-FoD:\\a\\1\\s\\target\\debug\\build\\generator-cb101e03a46c8720\\out\\src/detail/asm\\asm_i386_ms_pe_masm.o" "-c" "src/detail/asm\\asm_i386_ms_pe_masm.asm" with args "ml.exe" did not execute successfully (status code exit code: 1).
carllerche added a commit to tokio-rs/tokio that referenced this issue Jan 21, 2020
Loom currently does not compile on windows due to a
transitive dependency on `generator`. The `generator`
crate builds have started to fail on windows CI. Loom
is not run under windows, however, so removing the
loom dependency on windows is sufficient to fix CI.

Refs: Xudong-Huang/generator-rs#19
@Xudong-Huang
Copy link
Owner

Xudong-Huang commented Jan 22, 2020

Seems that the i686 target is not well supported. Is it possible to run the test on TARGET="x86_64-pc-windows-msvc"?

I will try to fix this for the i686 target.

@carllerche
Copy link
Author

Thanks for the reply and I appreciate the work maintaining generator. It has been super useful for loom.

We have worked around by disabling our loom tests on windows, so we are not blocked :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants