Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cobuild support #8

Closed
wants to merge 5 commits into from
Closed

Cobuild support #8

wants to merge 5 commits into from

Conversation

XuJiandong
Copy link
Owner

@XuJiandong XuJiandong commented Jan 19, 2024

This PR is for review only since the target branch "migrate-pr" is still not merged.

Comments for review:

  1. The main implementation is in cobuild.c.
  2. The words "tested by" in cobuild.c means the branch is covered by corresponding test case.
  3. The lazy reader is implemented in cobuild.c. No matter how large the transaction is, the total memory consumption is fixed(~2K for global and ~4K for stack). We have test case for it.

XuJiandong and others added 5 commits January 22, 2024 14:34
* Add missing auth id(0x02~0x05)

migrate PR from: nervosnetwork/ckb-production-scripts#75

including
* eos
* tron
* bitcoin(Support UniSat and OKX wallet)
* dogecoin

Special feature for btc/etc, now they can display meaningful messages.

* BTC(UniSat/OKX)
You're signing:
CKB (Bitcoin Layer-2) transaction: 0x{sighash_all in hex}

* ETH(Metamask)
You're signing:
CKB transaction: 0x{sighash_all in hex}

* Fix: Remove btc testcase annotation (#2)

* Change Bitcoin Prefix (#10)

---------

Co-authored-by: joii2020 <[email protected]>
migrate PR from: nervosnetwork/ckb-production-scripts#75

including
* eos
* tron
* bitcoin(Support UniSat and OKX wallet)
* dogecoin

Special feature for btc/etc, now they can display meaningful messages.

* BTC(UniSat/OKX)
You're signing:
CKB (Bitcoin Layer-2) transaction: 0x{sighash_all in hex}

* ETH(Metamask)
You're signing:
CKB transaction: 0x{sighash_all in hex}
* Add test cases for cobuild
* Update ckb-* to 0.113.0 and rust-toolchain
* Add testcase: test_big_message
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants