π Fix compulsory inPort args in new compiler #211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently the new compiler does not compile any xircuits canvas that has compulsory inPorts which is indicated as [β ]. As currently Xircuits bakes the β into the label, it breaks the compiler due to β being a a special character.
This PR updates the compiler to read .xircuits files using utf-8 encoding, then filters β from port strings.
References
#209
#210
Pull Request Type
Type of Change
Tests
Take the wheel and try compiling
examples/KerasTrainImageClassifier.xircuits
. It should correctly compile.Tested on?
Notes
In the future we should rethink baking the β in the label.