Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add concat component and add typing. #202

Merged
merged 3 commits into from
Feb 14, 2023
Merged

Add concat component and add typing. #202

merged 3 commits into from
Feb 14, 2023

Conversation

wmeddie
Copy link
Member

@wmeddie wmeddie commented Feb 7, 2023

Description

Adds some typing and useful components to the base component library.

Pull Request Type

  • Xircuits Core (Jupyterlab Related changes)
  • Xircuits Canvas (Custom RD Related changes)
  • Xircuits Component Library
  • Xircuits Project Template
  • Testing Automation
  • Documentation
  • Others (Please Specify)

Type of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Tests

Tested on?

  • Windows
  • Linux Ubuntu
  • Centos
  • Mac
  • Others (State here -> xxx )

Notes

MFA-X-AI
MFA-X-AI approved these changes Feb 14, 2023
View reviewed changes
Copy link
Member

@MFA-X-AI MFA-X-AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the scikit-learn packaged and fixed the concat logic, works perfectly now. Thanks!

@MFA-X-AI MFA-X-AI merged commit 050427c into master Feb 14, 2023
@MFA-X-AI MFA-X-AI deleted the more-utils branch February 14, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MFA-X-AI MFA-X-AI MFA-X-AI approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wmeddie @MFA-X-AI