Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tidy up the win32 build #916

Closed
totaam opened this issue Jul 15, 2015 · 10 comments
Closed

tidy up the win32 build #916

totaam opened this issue Jul 15, 2015 · 10 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Jul 15, 2015

Issue migrated from trac ticket # 916

component: platforms | priority: major | resolution: fixed | keywords: win32 64-bit

2015-07-15 05:40:05: totaam created the issue


Related to #678 and #640.

  • building on 64-bit windows system is painful, r9920 fixes most of that
  • we have too many inconsistent paths dumping in to C:\
@totaam
Copy link
Collaborator Author

totaam commented Jul 15, 2015

2015-07-15 06:10:29: totaam changed status from new to assigned

@totaam
Copy link
Collaborator Author

totaam commented Jul 15, 2015

2015-07-15 06:10:29: totaam changed owner from antoine to totaam

@totaam
Copy link
Collaborator Author

totaam commented Jul 15, 2015

2015-07-15 06:10:29: totaam commented


As of r9921, we can now move all the build libs into a prefix, it still defaults to C:\ for backwards compatibility, but I've moved my test build system to use E:\Xpra-Build-Libs which now looks like this:

ffmpeg2-win32-bin
libwebp-windows-x86
Microsoft.VC90.CRT
Microsoft.VC90.MFC
vpx-1.4
x264

This could also be used to lock a specific version to a specific set of libraries.

Note: we now support both 32-bit and 64-bit helpers (ghoscript for printing, etc) - we still prefer the 32-bit version if present so that we can build 32-bit installers on a 64-bit system which may have both versions of the tools. This has negligible cost: printing is not performance critical, but may have security implications as 64-bit tends to be safer. (this could be changed later)

@totaam
Copy link
Collaborator Author

totaam commented Jul 17, 2015

2015-07-17 04:42:13: totaam commented


For the record, this is how I built stuff with msvc 2008:

nmake -f makefile.vc setup-vc6
nmake -f makefile.vc

Then copy the headers and lib files to the python installation directories.

  • build as per its README, but changing to a dynamic build: nmake /f Makefile.vc CFG=release-dynamic RTLIBCFG=dynamic OBJDIR=output
  • copy the include and lib files as per python3 and gtk3 support #90#comment:38

Not done yet:

@totaam
Copy link
Collaborator Author

totaam commented Jul 27, 2015

2015-07-27 13:47:02: antoine changed status from assigned to new

@totaam
Copy link
Collaborator Author

totaam commented Jul 27, 2015

2015-07-27 13:47:02: antoine changed owner from totaam to smo

@totaam
Copy link
Collaborator Author

totaam commented Jul 27, 2015

2015-07-27 13:47:02: antoine commented


10052 backported this to v0.14.x and v0.15.x, and we can now have a different lib directory for each branch.
ie: v0.15.x will try to find:

  • E:\Xpra-Build-Libs-v0.15.x\
  • E:\Xpra-Build-Libs\
  • C:\
    So everything should work as before for all branches, and you can either use a common directory for all, or individual directories as needed.

@smo: please close to ACK, assuming nothing is broken...

@totaam
Copy link
Collaborator Author

totaam commented Sep 24, 2015

2015-09-24 23:04:01: smo changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Sep 24, 2015

2015-09-24 23:04:01: smo set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Sep 24, 2015

2015-09-24 23:04:01: smo commented


Tested this works as expected. I will probably leave mine at the default location for now but I like how this works now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant