python3 and gtk3 support #90

totaam · 2012-03-27T08:53:09Z

Issue migrated from trac ticket # 90

component: core | priority: major | resolution: fixed

2012-03-27 08:53:09: antoine created the issue

Makes sense to bundle this together since python3 is only really supported with gtk3 and vice versa.

Main work items:

backwards compatible python3 changes (via 2to3 mostly), most already done in r618, r619, r620, r621 and r622

python3 strings: changes need testing on python2.5, also need to ensure that calling encode(..) and decode(..) does not adversely affect performance

for other non-backwards compatible python3 changes, find a way to run 2to3 during build so we can keep a unified source tree in python2 format. (main issue here: catch exception syntax change)

gtk3 imports have moved and now require annotation to silence pydev lint

gtk3 methods on gtk.Window have changed, client.py will need to provide wrapper methods:

gdk.get_default_root_window().get_pointer() (removed)

gdk.get_default_root_window().get_size() (removed)

gtk.Window.__init__(win, wintype) (removed: no arg constructor now)

window.set_geometry_hints(...) (signature changed)

window.flags() (removed - must call get_$FLAGNAME)

window.window.set_cursor(..) (renamed to window.override_cursor?)

window.window.invalidate_rect (now window.queue_draw_area)

do_expose_event(event) is now do_draw(context)

window.window.get_geometry (removed, must now call get_position() and get_size()?)

constants have moved

gdk.keymap_get_default (removed?)

gdk.Cursor can no longer use pixbuf..

...

gtk3 removed GdkPixmap and GdkImage, we're supposed to be using cairo but cairo.ImageSurface.create_for_data is not implemented in pycairo and there are no alternatives (ouch!)

PIL (Python Imaging Library) is not available on python3 (so we can't use that to fix cairo either)

The text was updated successfully, but these errors were encountered:

totaam · 2012-03-27T12:32:55Z

2012-03-27 12:32:55: antoine changed status from new to accepted

totaam · 2012-03-27T12:32:55Z

2012-03-27 12:32:55: antoine commented

More done in r626, r627, r628, r629 and r630: most of the code is now python3/gtk3 compatible, except for:

client.py (large changes due to cairo brokenness)

protocol.py (string encoding changes - painful as this as repercussions elsewhere)

totaam · 2012-03-27T20:10:02Z

2012-03-27 20:10:02: antoine commented

Some useful links:

GObject Introspection

Introspection Porting

Migrating from GTK+ 2.x to GTK+ 3 (and in particular changes that need to be done at the time of the switch)

GTK+ 3 Reference Manual

The Python GTK+ 3 Tutorial

Converting PIL Image to GTK Pixbuf

pygi-convert.sh

Ubuntu app indicators when using PyGObject (grrr)

Convert PIL Image to Cairo ImageSurface

PIL and Cairographics / PyCairo

cairo.ImageSurface.create_for_data

totaam · 2012-03-27T20:10:02Z

2012-03-27 20:10:02: antoine

totaam · 2012-03-27T20:10:02Z

2012-03-27 20:10:02: antoine

totaam · 2012-03-28T08:50:54Z

2012-03-28 08:50:54: antoine uploaded file `xpra-gtk3.patch` (33.0 KiB)

rough patch for gtk3/python3 support

totaam · 2012-03-28T08:58:18Z

2012-03-28 08:58:18: antoine commented

The patch above "works" in the sense that one can get something on screen with gtk3, but it has a number of important shortcomings:

problems with the new StringIO class, which fails because of a missing fileno()

jpeg and rgb24 have to be parsed using PIL then exported to PNG to then be loaded by cairo as cairo is incapable of loading anything else (seriously!? gtk devs, this is not an upgrade by a giant leap backwards). For rgb24 it seems to require an unnecessarily large rowstride (RGBA? according to this answer it uses 32 bit per channel data no matter what) - which we do not control as it is generated by gdk on the server side. This means making png the default and finding a solution for the mmap case: possibly using cairo server side to export with the rowstride expected by cairo on the client? Maybe also moving the draw/expose code to a utility class so we can use the current code on gtk2 and the new horrible mess on gtk3 only.

some re-drawing problems due to coordinates and clipping interfering with each other (shouldn't be too hard to fix)

totaam · 2012-03-28T08:58:18Z

2012-03-28 08:58:18: antoine

totaam · 2012-03-28T18:31:06Z

2012-03-28 18:31:06: antoine commented

r640 makes python3 + gtk3 almost usable by providing two different window backing mechanisms (we keep the old/fast code for gtk2, cairo for gtk3).
But there are still many issues remaining:

most of the gtk3 function stubs at the top of client.py are still missing an actual implementation (no cursors, no keyboard support, etc)

display = gdk.display_get_default() and watching for screen changes has been hacked out with a if not is_gtk3() guard

the gtk3 version of the tray menu is mostly broken due to api changes: missing icons, about dialog errors, etc

totaam · 2012-03-28T18:31:06Z

2012-03-28 18:31:06: antoine

totaam · 2012-03-30T13:44:20Z

2012-03-30 13:44:20: antoine commented

r654 fixes the about dialog

r653 fixes the session info dialog

totaam · 2012-03-30T15:48:45Z

2012-03-30 15:48:45: antoine commented

r667 fixes get_modifiers_mask, set_geometry_hints and is_flag_set vs MAPPED/REALIZED

totaam · 2012-04-04T07:10:08Z

2012-04-04 07:10:08: antoine commented

There are serious compatibility issues between the new io.StringIO module and PIL, r697 reverts back to StringIO.StringIO in order to fix window icons - this will cause problems when trying to port the server to gtk3/python3.

totaam · 2012-05-04T10:48:56Z

2012-05-04 10:48:56: antoine

totaam · 2012-05-04T10:48:56Z

2012-05-04 10:48:56: antoine commented

delayed, this is hard!

totaam · 2012-09-27T16:23:25Z

2012-09-27 16:23:25: antoine

totaam · 2013-07-16T07:10:28Z

2013-07-16 07:10:28: antoine changed status from accepted to new

totaam · 2013-07-16T07:10:28Z

2013-07-16 07:10:28: antoine

totaam · 2013-07-16T07:10:28Z

2013-07-16 07:10:28: antoine commented

Worth updating and getting the basics to work properly (keyboard, etc)

And maybe also: transparency, GL, cursors, ..

totaam · 2013-07-16T07:10:28Z

2013-07-16 07:10:28: antoine

totaam · 2013-07-16T07:10:28Z

2013-07-16 07:10:28: antoine

totaam · 2013-10-17T08:47:28Z

2013-10-17 08:47:28: totaam

totaam · 2013-10-17T08:47:28Z

2013-10-17 08:47:28: totaam commented

too much work, too little time

totaam · 2014-04-27T14:04:10Z

2014-04-27 14:04:10: antoine commented

Lots of updates, this may be a better option than #300:

misc fixes: r6205, r6203, r6194, r6192, r6191, r6190, r6208

py3k string mess: r6189, r6184, r6183, r6181, r6179+r6180, r6178

build updates: r6188, r6177, r6176 (broke rencode python build on win32 - fixed by r6211), r6210, r6213, r6214, r6215

refactoring: r6202

gtk3 x11: r6201, r6200, r6199

mouse and beep support: r6206, r6207

re-use new buffer code (see improve picture buffer handling #465): r6198, r6212

ugly cairo mess: r6197, r6196, r6187, r6186, r6185 (last three are candidates for backports)

support for icons: r6195

support for system tray: r6193

It is in a much better shape now, including some keyboard support.

[[BR]]

Things that just need more work:

transparency (should now work on osx and win32 without opengl?)

window state (fullscreen, etc)

spinner

workspaces

launcher

session info and about dialog

clipboard (oh joy)

sound (gstreamer 1.x)

osx integration work (..)

[[BR]]

Things that won't work out of the box with python3:

py2exe does not support python3 at all, maybe use cx_freeze (the python documentation claims to be able to generate installers directly, I doubt this will work well enough for our needs but worth a try: distutils builtdist: creating windows installers)

gtkglext and pygtkglext aren't supported with gtk3... tegtkgl claims to be GTK+ 3.0 OpenGL widget, or maybe this gtkglext port to GTK+ 3 - Note: A git build is included below as part of the pygobjectwin32 installer.

[[BR]]

python netifaces does not support py3k

MS Windows issues

GTK (what a mess):

pygobjectwin32 seems to be the place to get everything - the alternative would be to build from source with mingw and jhbuild...

[[BR]]

Things that install OK on win32 via installers (preferred):

pywin32

[[BR]]

Things that install OK on win32 via scripts\pip.exe install or py -3 -m pip install:

Pillow

PyOpenGL (but PyOpenGL_accelerate needs a C compiler, see below)

[[BR]]

Things that need a C compiler to install on win32. Note: I have used mingw32 as per [http://stackoverflow.com/questions/3297254/how-to-use-mingws-gcc-compiler-when-installing-python-package-using-pip ] instead of Visual Studio 2010 normally used with Python 3.4 because I already have Visual Studio 2008 installed for Python 2.7... for now.

lz4

numpy (although binaries are available on their website, it is best to use pip to ensure we get clean and easy updates)

PyOpenGL_accelerate

Cython

pycrypto (needs to have chmod.exe on the PATH)

wmi

totaam · 2014-04-27T14:04:10Z

2014-04-27 14:04:10: antoine

totaam · 2014-04-27T14:04:10Z

2014-04-27 14:04:10: antoine

totaam · 2014-04-27T14:04:10Z

2014-04-27 14:04:10: antoine

totaam · 2014-04-27T14:04:10Z

2014-04-27 14:04:10: antoine

totaam · 2014-04-27T14:04:10Z

2014-04-27 14:04:10: antoine

totaam · 2014-04-27T14:04:10Z

2014-04-27 14:04:10: antoine

totaam · 2015-04-20T20:05:59Z

2015-04-20 20:05:59: maxmylyn changed status from new to closed

totaam · 2015-04-20T20:05:59Z

2015-04-20 20:05:59: maxmylyn set resolution to fixed

totaam · 2015-04-20T20:05:59Z

2015-04-20 20:05:59: maxmylyn commented

Retried with the following builds against an r9087 Fedora 21 server:

MSVC:

Client connected and gave me my windows (currently starting with Firefox, xterm, xterm), however, I was unable to right click on the tray icon to disconnect

in addition a CTRL-C to the CMD window started a disconnect but then the client hung, before closing but not exiting completely.
Got the following output from the server:
2015-04-20 11:35:25,311 client Protocol(SocketConnection(('10.0.32.137', 2200) - ('10.0.11.113', 59162))) has requested disconnection: CTRL_C
2015-04-20 11:35:25,311 Disconnecting client Protocol(SocketConnection(('10.0.32.137', 2200) - ('10.0.11.113', 59162))): client request
2015-04-20 11:35:25,328 internal error: read connection SocketConnection(('10.0.32.137', 2200) - ('10.0.11.113', 59162)) reset: [Errno 104] Connection reset by peer
However, a re-launch(closing the CMD window and opening a new one) with and without OpenGl works as expected. Must have been a one-time fluke, but I can investigate further if needed

MinGW:

I get a generic error ("blah" has stopped working, Windows isn't checking to fix it, etc etc) on disconnect every time. Other than that it works as expected.

edit: I see the caveat on #640 now. I'll refrain from posting the obvious and leave this be.

No longer asking about the E: drive.

Will mention the generic error in Python3 GTK3 client feature parity #640.

Closing.

totaam · 2015-04-20T20:05:59Z

2015-04-20 20:05:59: maxmylyn

totaam · 2015-04-20T20:05:59Z

2015-04-20 20:05:59: maxmylyn

totaam closed this as completed Apr 20, 2015

totaam mentioned this issue Jul 13, 2021

osx modulesets for building GTK3 + gobject-introspection bindings Xpra-org/gtk-osx-build#16

Closed

gdkrmr mentioned this issue Apr 15, 2023

run_scaled thunderbird crashes #3814

Closed

python3 and gtk3 support #90

python3 and gtk3 support #90

Comments

totaam commented Mar 27, 2012

2012-03-27 08:53:09: antoine created the issue

totaam commented Mar 27, 2012

2012-03-27 12:32:55: antoine changed status from new to accepted

totaam commented Mar 27, 2012

2012-03-27 12:32:55: antoine commented

totaam commented Mar 27, 2012

2012-03-27 20:10:02: antoine commented

totaam commented Mar 27, 2012

2012-03-27 20:10:02: antoine

totaam commented Mar 27, 2012

2012-03-27 20:10:02: antoine

totaam commented Mar 28, 2012

2012-03-28 08:50:54: antoine uploaded file xpra-gtk3.patch (33.0 KiB)

totaam commented Mar 28, 2012

2012-03-28 08:58:18: antoine commented

totaam commented Mar 28, 2012

2012-03-28 08:58:18: antoine

totaam commented Mar 28, 2012

2012-03-28 18:31:06: antoine commented

totaam commented Mar 28, 2012

2012-03-28 18:31:06: antoine

totaam commented Mar 30, 2012

2012-03-30 13:44:20: antoine commented

totaam commented Mar 30, 2012

2012-03-30 15:48:45: antoine commented

totaam commented Apr 4, 2012

2012-04-04 07:10:08: antoine commented

totaam commented May 4, 2012

2012-05-04 10:48:56: antoine

totaam commented May 4, 2012

2012-05-04 10:48:56: antoine commented

totaam commented Sep 27, 2012

2012-09-27 16:23:25: antoine

totaam commented Jul 16, 2013

2013-07-16 07:10:28: antoine changed status from accepted to new

totaam commented Jul 16, 2013

2013-07-16 07:10:28: antoine

totaam commented Jul 16, 2013

2013-07-16 07:10:28: antoine commented

totaam commented Jul 16, 2013

2013-07-16 07:10:28: antoine

totaam commented Jul 16, 2013

2013-07-16 07:10:28: antoine

totaam commented Oct 17, 2013

2013-10-17 08:47:28: totaam

totaam commented Oct 17, 2013

2013-10-17 08:47:28: totaam commented

totaam commented Apr 27, 2014

2014-04-27 14:04:10: antoine commented

MS Windows issues

totaam commented Apr 27, 2014

2014-04-27 14:04:10: antoine

totaam commented Apr 27, 2014

2014-04-27 14:04:10: antoine

totaam commented Apr 27, 2014

2014-04-27 14:04:10: antoine

totaam commented Apr 27, 2014

2014-04-27 14:04:10: antoine

totaam commented Apr 27, 2014

2014-04-27 14:04:10: antoine

totaam commented Apr 27, 2014

2014-04-27 14:04:10: antoine

totaam commented Apr 20, 2015

2015-04-20 20:05:59: maxmylyn changed status from new to closed

totaam commented Apr 20, 2015

2015-04-20 20:05:59: maxmylyn set resolution to fixed

totaam commented Apr 20, 2015

2015-04-20 20:05:59: maxmylyn commented

totaam commented Apr 20, 2015

2015-04-20 20:05:59: maxmylyn

totaam commented Apr 20, 2015

2015-04-20 20:05:59: maxmylyn

2012-03-28 08:50:54: antoine uploaded file `xpra-gtk3.patch` (33.0 KiB)