Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

launcher crashes if we click on the encoding drop down a few times #864

Closed
totaam opened this issue May 18, 2015 · 8 comments
Closed

launcher crashes if we click on the encoding drop down a few times #864

totaam opened this issue May 18, 2015 · 8 comments

Comments

@totaam
Copy link
Collaborator

totaam commented May 18, 2015

Issue migrated from trac ticket # 864

component: client | priority: blocker | resolution: fixed | keywords: win32

2015-05-18 12:21:59: antoine created the issue

@totaam
Copy link
Collaborator Author

totaam commented May 18, 2015

2015-05-18 12:32:58: antoine uploaded file debug-launcher-crash.patch (1.4 KiB)

adds some debug logging

@totaam
Copy link
Collaborator Author

totaam commented May 18, 2015

2015-05-18 15:07:23: antoine changed owner from antoine to afarr

@totaam
Copy link
Collaborator Author

totaam commented May 18, 2015

2015-05-18 15:07:23: antoine commented


This was caused by the fix for #724: somehow firing the extra event really confuses GTK on win32. No idea why.
The fix is ugly but simple: we temporarily disable the workaround when the widgets are not used from the tray.

Applied in r9439, backport to v0.15.x and v0.14.x in 9441.

@afarr: can you or Branden still cause some kind of crashes?

It is worth mentioning that I had seen the launcher crash on OSX before, just as you click on the host field to type it in. I'm not seeing this anymore, maybe it is related.

@totaam
Copy link
Collaborator Author

totaam commented May 22, 2015

2015-05-22 06:12:03: afarr changed owner from afarr to antoine

@totaam
Copy link
Collaborator Author

totaam commented May 22, 2015

2015-05-22 06:12:03: afarr commented


Tested with win32 0.15.0 9470 against both fedora 20 0.15.0 9470 built --with-memoryviews and fedora 20 0.15.0 r9374 without servers.

I couldn't cause any crashes no matter what I tried, including connecting with AES and a password file.

I think this one is good to close.

@totaam
Copy link
Collaborator Author

totaam commented May 22, 2015

2015-05-22 06:12:47: totaam changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented May 22, 2015

2015-05-22 06:12:47: totaam set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented May 22, 2015

2015-05-22 06:12:47: totaam commented


Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant