System tray not able to change options with mix of left and right clicks

[totaam]

Issue migrated from trac ticket # 724

component: client | priority: blocker | resolution: fixed

2014-10-31 15:07:08: rikky created the issue

---

I can not change any option from the xpra tray. Tried to change Encoding, Quality,Speed, Speaker, Microphone, Keyboard. Only "Keyboards Synchronization" can be changed. May be related to submenus?

I had this behavior for many versions (I guess since the 0.12.x), but I blamed my old ubuntu installation. After updating to newer Ubuntu the issue persists.

Server: Ubuntu 14.04 with Xpra 0.14.10
Client: Windows 7 with Xpra 0.14.10

[totaam]

2014-11-01 03:28:35: totaam changed owner from antoine to rikky

[totaam]

2014-11-01 03:28:35: totaam commented

---

If you right click on the tray to get the menu, you have to right click on the options. (same for left click)
Apart from that, there are no known issues with the tray menu. I doubt that the server version could influence that.

Does this happen with all sessions? Even with just an xterm as application?

Is this a regression? Did not occur with versions older than 0.12.x? If so, can you download older version to pinpoint when the problem started?

[totaam]

2014-11-03 12:18:00: rikky commented

---

You are right. I tend to right click on tray icons, but It never occured to me to right click on a menu item.

Since I could not find an existing bug report for this behavior, I would like to keep this one open. Would be nice to not close the menu when clicking with the wrong button, or even better always react on left click.

[totaam]

2014-11-03 14:11:37: totaam changed title from System tray on Windows not able to change options to System tray on Windows not able to change options with mix of left and right clicks

[totaam]

2014-11-03 14:11:37: totaam commented

---

I believe I have just come up with a quick fix for this bug.
Can you please test it for me? Then I can commit and backport it.
There is a beta windows build (named r8044M)

[totaam]

2014-11-03 14:12:01: totaam uploaded file tray-mixed-clicks.patch (3.6 KiB)

proposed fix

[totaam]

2014-11-04 11:53:15: rikky commented

---

The beta build did not fix the issue. The options don´t change when left clicking on a menu item after opening the tray menu with a right click. But there is an additional issue. After opening the menu with a right click and clicking on an option with a right click, the old option is not removed and you see multiple active options.

[totaam]

2014-11-04 14:31:04: totaam commented

---

Wait, I've just tried again and I am unable to reproduce the bug, even with older builds. What am I missing?
Can you give us a more detailed, step by step reproduction?
I've tried left then right, right then left, no difference, both work, even with older versions. Tested with XP and Windows 7 Ultimate 64-bit.

[totaam]

2014-11-06 15:20:43: rikky commented

---

Ok I´ll try:

1. right click on the Xpra tray icon
2. Move the mouse over "Encoding", to open that sub menu (I did not click it)
3. left click on JPEG

The menu will close. But if you open the menu again, the old encoding is still active and not JPEG.

[totaam]

2014-11-06 15:22:38: totaam changed status from new to assigned

[totaam]

2014-11-06 15:22:38: totaam changed owner from rikky to totaam

[totaam]

2014-11-06 15:22:38: totaam commented

---

Right, my bad. It's only (edited) radio checkboxes.
Let me see what I can do.

[totaam]

2014-11-07 03:34:22: totaam changed status from assigned to new

[totaam]

2014-11-07 03:34:22: totaam changed owner from totaam to rikky

[totaam]

2014-11-07 03:34:22: totaam changed title from System tray on Windows not able to change options with mix of left and right clicks to System tray not able to change options with mix of left and right clicks

[totaam]

2014-11-07 03:34:22: totaam commented

---

The proposed fix was almost right, but not quite.
Once I knew how to reproduce, it was a bit easier to figure out: r8064 fixes this.
Will backport.

I've also edited the bug title to remove "windows" because this also affected other platforms - it was just a bit harder to hit.

@rikki: new beta build 8064
does that fix things for you?

[totaam]

2014-11-10 08:18:56: rikky changed status from new to closed

[totaam]

2014-11-10 08:18:56: rikky changed resolution from ** to fixed

[totaam]

2014-11-10 08:18:56: rikky commented

---

r8064 works great. Thanks.

[totaam]

2014-11-14 18:20:00: totaam commented

---

Backport for v0.14.x was in 8074.

We also need r8113 to avoid breaking the gtk3 port.. (backported in 8116)

[totaam]

2015-04-14 19:04:56: antoine changed priority from minor to blocker

[totaam]

2015-04-14 19:04:56: antoine changed status from closed to reopened

[totaam]

2015-04-14 19:04:56: antoine removed resolution (was fixed)

[totaam]

2015-04-14 19:04:56: antoine commented

---

Re-opening: I am seeing some problems with this code, both with the speed / quality sub menus and with the callbacks firing multiple times (blocking #808#comment:8).

[totaam]

2015-04-14 19:30:29: antoine changed status from reopened to new

[totaam]

2015-04-14 19:30:29: antoine changed owner from rikky to antoine

[totaam]

2015-04-14 19:30:29: antoine commented

---

This is fixed (again - but properly this time?) in r9002.

Needs backporting so keeping this ticket open.

[totaam]

2015-04-15 07:47:18: antoine changed status from new to closed

[totaam]

2015-04-15 07:47:18: antoine set resolution to fixed

[totaam]

2015-04-15 07:47:18: antoine commented

---

Backport in r9002. Works fine so closing. Feel free to re-open if I've missed something.

[totaam]

2015-05-18 14:26:21: antoine commented

---

FYI: this caused a bug somewhere else on win32: #864.

[totaam]

2015-05-18 16:05:39: antoine commented

---

r9442 changes the code so we only ever enable the workaround on win32 (trunk 0.16 only)

[totaam]

2018-08-19 14:35:25: antoine commented

---

The problem may have reappeared: #1907