Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

authentication module to inspect http headers #4438

Closed
totaam opened this issue Dec 10, 2024 · 1 comment
Closed

authentication module to inspect http headers #4438

totaam opened this issue Dec 10, 2024 · 1 comment
Labels

Comments

@totaam
Copy link
Collaborator

totaam commented Dec 10, 2024

For example, we should be able to enforce SSL.

The proxy can give us X-Forwarded-Proto and we should be able to reject http.

Related to #4437 and #4435.

@totaam
Copy link
Collaborator Author

totaam commented Dec 10, 2024

Done in the commit above, defaults to checking for X-Forwarded-Proto=https, so:

xpra seamless --start=xterm \
    --bind-ws=0.0.0.0:10000,auth=http-header

Is equivalent to:

xpra seamless --start=xterm \
    --bind-ws="0.0.0.0:10000,auth=http-header,property=X-Forwarded-Proto,value=https"

Beware to only use this header check when the headers can be trusted!
(ie: if the xpra server is only reachable via a proxy server that will validate / set the headers in question)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant