Xpra-x86_64_6.0-r34433 issues

[stdedos]

Describe the bug

"Xpra-x86_64_6.0-r34433\xpra_cmd" shadow ssh://user@ip/1 --ssh="plink -ssh -agent" --modal-windows=no --headerbar=off --source-start=gnome-keyring-daemon --title="@title@ on @@/@server-display@" --encodings=-webp --start="nohup systemd-inhibit --what=handle-lid-switch sleep 1d >/dev/null 2>&1 & inhibit_pid=\$! ; xpra xwait ; kill -9 \$inhibit_pid ; nohup systemd-inhibit --what=handle-lid-switch sleep 5m >/dev/null 2>&1 &" --microphone=off --speaker=off --webcam=no --pulseaudio=no --opengl=no --key-shortcut=Shift+F2:toggle_pointer_grab

XPRA_EXECUTABLE=Xpra-x86_64_6.0-r34433

Note: GDK_WIN32_DISABLE_HIDPI is ignored due to preset
      DPI awareness settings in user settings or application
      manifest, DPI awareness is still enabled.2023-10-05 20:22:13,434 Xpra GTK3 client version 6.0-r34433 (ge0a893aa3) beta
2023-10-05 20:22:13,445  running on Microsoft Windows
2023-10-05 20:22:13,445  cpython 3.11
2023-10-05 20:22:15,441 GStreamer version 1.22.6
2023-10-05 20:22:15,599 created named pipe 'Xpra\\228'
2023-10-05 20:22:15,680 Error importing dec_avif (avif decoder)
2023-10-05 20:22:15,681  DLL load failed while importing decoder: Δεν ήταν δυνατό να εντοπιστεί η καθορισμένη λειτ. μονάδα.
2023-10-05 20:22:15,837 Error setting up the pipeline:
2023-10-05 20:22:15,838  gst_parse_error: could not link decoder to sink (3)
2023-10-05 20:22:15,839  GStreamer pipeline for:
2023-10-05 20:22:15,839   appsrc name=src emit-signals=1 block=0 is-live=1 do-timestamp=1 stream-type=0 format=2 caps=video/x-h264,width=128,height=128,profile=(string)main,stream-format=(string)byte-stream,alignment=(string)au ! \
2023-10-05 20:22:15,839   d3d11h264dec name=decoder ! \
2023-10-05 20:22:15,840   appsink name=sink emit-signals=1 max-buffers=10 drop=false sync=false async=true qos=false caps=video/x-raw,width=128,height=128,format=(string)I420
2023-10-05 20:22:15,840 Error creating context h264 128x128 YUV420P
2023-10-05 20:22:15,840 gstreamer: h264 decoding failed: failed to setup gstreamer pipeline
2023-10-05 20:22:15,862 keyboard layout 'United States - English' : 'us' (0x409)
2023-10-05 20:22:15,994  keyboard settings: layout=us
2023-10-05 20:22:15,997  desktop size is 4480x1516:
2023-10-05 20:22:15,997   Default (1185x401 mm - DPI: 96x96) workarea: 4480x1476
2023-10-05 20:22:15,997     Samsung C32JG5x  2560x1440 at    0x0    (697x392 mm - DPI: 93x93) workarea: 2560x1400
2023-10-05 20:22:15,998     LG IPS234        1920x1080 at 2560x436  (510x290 mm - DPI: 96x95) workarea: 1920x1040 at 2560x436
2023-10-05 20:22:25,802 enabled remote logging
2023-10-05 20:22:25,803 Xpra shadow server version 5.0
2023-10-05 20:22:25,804  remote desktop size is 1920x1200
2023-10-05 20:22:25,804   :1.0 (508x318 mm - DPI: 96x96) workarea: 1848x1173 at   72x27
2023-10-05 20:22:25,805     LGD eDP-1        (336x210 mm - DPI: 145x145)
2023-10-05 20:22:26,141 running, 1 windows

(xpra_cmd:228): Pango-WARNING **: 20:22:26.995: couldn't load font "DejaVu Serif Not-Rotated 59.796875", falling back to "Sans Not-Rotated 59.796875", expect ugly output.

(xpra_cmd:228): Pango-WARNING **: 20:22:27.015: couldn't load font "URW Bookman L Not-Rotated 52.76171875", falling back to "Sans Not-Rotated 52.76171875", expect ugly output.
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1677: DeprecationWarning: Gtk.Menu.popup_for_device is deprecated
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "n_rows, n_columns, homogeneous" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: DeprecationWarning: Gtk.Table.set_col_spacings is deprecated
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: DeprecationWarning: Gtk.Table.set_row_spacings is deprecated
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: DeprecationWarning: Gtk.Widget.modify_fg is deprecated
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: DeprecationWarning: Gtk.Alignment.set_padding is deprecated
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: DeprecationWarning: Gtk.Widget.modify_bg is deprecated
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1543: DeprecationWarning: Gtk.Table.attach is deprecated
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "n_rows, n_columns, homogeneous" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "n_rows, n_columns, homogeneous" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "n_rows, n_columns, homogeneous" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "n_rows, n_columns, homogeneous" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: DeprecationWarning: Gdk.Cursor.new is deprecated
2023-10-05 20:22:41,194 Error: cannot import python-cryptography
2023-10-05 20:22:55,369 Error: cannot import python-cryptography
2023-10-05 20:22:55,470 Error: cannot import python-cryptography
2023-10-05 20:22:55,572 Error: cannot import python-cryptography
2023-10-05 20:22:55,673 Error: cannot import python-cryptography
2023-10-05 20:22:55,773 Error: cannot import python-cryptography
2023-10-05 20:22:55,879 Error: cannot import python-cryptography
...

To be precise:

1. Newline in manifest, DPI awareness is still enabled.2023-10-05 20:22:13,434 Xpra GTK3 client version 6.0-r34433 (ge0a893aa3) beta

2. 2023-10-05 20:22:15,680 Error importing dec_avif (avif decoder)
   2023-10-05 20:22:15,681  DLL load failed while importing decoder: Δεν ήταν δυνατό να εντοπιστεί η καθορισμένη λειτ. μονάδα.
   

3. 2023-10-05 20:22:15,837 Error setting up the pipeline:
   2023-10-05 20:22:15,838  gst_parse_error: could not link decoder to sink (3)
   2023-10-05 20:22:15,839  GStreamer pipeline for:
   2023-10-05 20:22:15,839   appsrc name=src emit-signals=1 block=0 is-live=1 do-timestamp=1 stream-type=0 format=2 caps=video/x-h264,width=128,height=128,profile=(string)main,stream-format=(string)byte-stream,alignment=(string)au ! \
   2023-10-05 20:22:15,839   d3d11h264dec name=decoder ! \
   2023-10-05 20:22:15,840   appsink name=sink emit-signals=1 max-buffers=10 drop=false sync=false async=true qos=false caps=video/x-raw,width=128,height=128,format=(string)I420
   

4. 2023-10-05 20:22:15,840 Error creating context h264 128x128 YUV420P
   

5. 2023-10-05 20:22:15,840 gstreamer: h264 decoding failed: failed to setup gstreamer pipeline
   

6. expect ugly output. ... if possible
7. Bunch of deprecation warnings
8. Neverending 2023-10-05 20:22:41,194 Error: cannot import python-cryptography

To Reproduce
Steps to reproduce the behavior:

1. server command
2. client command
3. specific action to trigger the bug

System Information (please complete the following information):

• Server OS: Ubuntu 20.04.6 LTS
• Client OS: Microsoft Windows [Version 10.0.18363.836]
• Xpra Server Version: (see above)
• Xpra Client Version: (see above)

Additional context
Add any other context about the problem here.
Please see "reporting bugs" in the wiki section.

Also, for some reason, xpra doesn't want to update on Ubuntu

uu@h [2023-10-0520:33:12] $ aug
...
Hit:16 https://xpra.org focal InRelease
...
Hit:20 https://xpra.org/beta focal InRelease
uu@h [2023-10-0520:37:51] $ apt-cache madison xpra
      xpra | 5.0.2-r0-1 | https://xpra.org focal/main amd64 Packages
      xpra | 5.0.1-r20-1 | https://xpra.org/beta focal/main amd64 Packages
      xpra | 5.0.1-r0-1 | https://xpra.org focal/main amd64 Packages
      xpra |   5.0-r0-1 | https://xpra.org focal/main amd64 Packages
      xpra | 4.4.6-r29-1 | https://xpra.org focal/main amd64 Packages
      xpra | 3.1.5-r0-1 | https://xpra.org focal/main amd64 Packages
      xpra | 3.0.6+dfsg1-1build1 | http://fi.archive.ubuntu.com/ubuntu focal/universe amd64 Packages
uu@h [2023-10-0520:37:55] $ apt-cache policy xpra
xpra:
  Installed: 5.0.2-r0-1
  Candidate: 5.0.2-r0-1
  Version table:
 *** 5.0.2-r0-1 500
        500 https://xpra.org focal/main amd64 Packages
        100 /var/lib/dpkg/status
     5.0.1-r20-1 500
        500 https://xpra.org/beta focal/main amd64 Packages
     5.0.1-r0-1 500
        500 https://xpra.org focal/main amd64 Packages
     5.0-r0-1 500
        500 https://xpra.org focal/main amd64 Packages
     5.4.6-r29-1 500
        500 https://xpra.org focal/main amd64 Packages
     3.1.5-r0-1 500
        500 https://xpra.org focal/main amd64 Packages
     3.0.6+dfsg1-1build1 500
        500 http://fi.archive.ubuntu.com/ubuntu focal/universe amd64 Packages
uu@h [2023-10-0520:38:08] $

so there's that too 😕

[stdedos]

2023-10-05 20:22:41,194 Error: cannot import python-cryptography seems to happen when opening the Session Info.

Specifically, the "Connect" tab

2023-10-05 20:39:02,946 Error: cannot import python-cryptography
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "n_rows, n_columns, homogeneous" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "n_rows, n_columns, homogeneous" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "n_rows, n_columns, homogeneous" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "n_rows, n_columns, homogeneous" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
C:/msys64/mingw64/lib/python3.11/site-packages/gi/overrides/Gtk.py:1694: PyGTKDeprecationWarning: Using positional arguments with the GObject constructor has been deprecated. Please specify keyword(s) for "n_rows, n_columns, homogeneous" or use a class specific constructor. See: https://wiki.gnome.org/PyGObject/InitializerDeprecations
2023-10-06 00:40:27,030 Error: cannot import python-cryptography

[totaam]

I believe that this r34433 build is one that has cythonize-more enabled: #3978
I will make sure that this recorded somewhere more visible.
This will not be the default but it is very useful for triggering latent bugs and more warnings than usual.

Newline in ...

That's going to be tricky to fix as the message that is missing the newline is not one of ours!
188a26a might help.

Error importing dec_avif

The problem here is that when I implemented avif (#3457) I didn't realize just how big the dependencies were.
For now, the warning will be silenced: c80ee17. The proper solution for MS Windows builds is likely to split into two

• light builds without avif or any of the nvidia codecs, without server support
• full builds with a much bigger footprint

Error setting up the pipeline:
(..)
d3d11h264dec name=decoder !

This should be improved by #3964
We have no way of really knowing what works and what doesn't with GStreamer, so we try different things and only keep the working ones as options.

Error creating context h264 128x128 YUV420P

Wasn't there more context with this error?

expect ugly output. ... if possible

Where? Is this one of ours?
I can't find it.

Bunch of deprecation warnings

That's #3978 and GTK adding more deprecation warnings to scare people.
The Gtk.Menu.popup_for_device I will silence because the non-deprecated variant just does not work!
The others will be replaced with Gtk.Grid, at some point after 6.0

Neverending Error: cannot import python-cryptography

Will look into it, likely also #3978 which confuses the application bundler.

xpra doesn't want to update on Ubuntu

Will check.

[totaam]

Turns out that I need the GUI code that triggers the Gtk.Table warnings for #3964, so I ended up fixing it properly.
Everything else should already be dealt with?

[totaam]

Looks fixed to me, please let me know if I've missed something.

[stdedos]

Most look good in Xpra-x86_64_6.0-r34669M, except

2023-11-11 22:15:40,676 Error setting up the pipeline:
2023-11-11 22:15:40,676  gst_parse_error: could not link decoder to sink (3)
2023-11-11 22:15:40,676  GStreamer pipeline for:
2023-11-11 22:15:40,676   appsrc name=src emit-signals=1 block=0 is-live=1 do-timestamp=1 stream-type=0 format=2 caps=video/x-h264,width=128,height=128,profile=(string)main,stream-format=(string)byte-stream,alignment=(string)au ! \
2023-11-11 22:15:40,677   d3d11h264dec name=decoder ! \
2023-11-11 22:15:40,677   appsink name=sink emit-signals=1 max-buffers=10 drop=false sync=false async=true qos=false caps=video/x-raw,width=128,height=128,format=(string)I420
2023-11-11 22:15:40,677 Error creating context h264 128x128 YUV420P
2023-11-11 22:15:40,677 gstreamer: h264 decoding failed: failed to setup gstreamer pipeline

and

(xpra_cmd:26268): Pango-WARNING **: 22:15:50.851: couldn't load font "Petyka - Retro Computer___SHORT Not-Rotated 17.98828125", falling back to "Sans Not-Rotated 17.98828125", expect ugly output.

(xpra_cmd:26268): Pango-WARNING **: 22:15:50.887: couldn't load font "DejaVu Serif Not-Rotated 59.796875", falling back to "Sans Not-Rotated 59.796875", expect ugly output.

(xpra_cmd:26268): Pango-WARNING **: 22:15:50.895: couldn't load font "URW Bookman L Not-Rotated 52.76171875", falling back to "Sans Not-Rotated 52.76171875", expect ugly output.

[totaam]

The gstreamer one is an ongoing issue with unpredictable gstreamer elements: #3964

The pango one is a pango / GTK feature. The problem with that one is that we don't control where it gets triggered from: it could also come from librsvg, our own dialogs, etc.. So best to just live with it.