-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
split codecs into a separate package #3651
Comments
Already done: See also #2344
|
Here is the new list of RPM names generated (excluding
And for DEBs:
|
because the libraries have weird names in Debian land, even if the development header packages do not. Also document the dependencies better, move some authentication libraries to 'Suggests' instead of 'Recommends', the sub-packages can depend on the main one rather than depending on a 'python3' package, remove all cuda bits from the main package
it is needed for interacting with a server
One downside of this change is that following the Debian build instructions at https://github.com/Xpra-org/xpra/blob/master/docs/Build/Debian.md now fails unless you have cuda installed whereas this used to produce a build without the codecs. See also Xpra-org/repo-build-scripts#7 |
After some investigation, the only problem is this line, because without what's needed for CUDA, this file is missing:
If it's commented out, the build is a success. Would it be possible to have an empty file always there for if CUDA isn't installed? |
That's what we used to do and I didn't like it because there was no way of knowing when the build failed to actually produce nvidia codecs without looking inside the package file, or relying on the file size somehow. |
* most codecs will import code from xpra-common, so make it required * both client and server work best with codecs installed, so make it recommended
We now have a |
When using xpra locally on the same (virtual) host using
mmap
orvsock
, none of the codecs should be used and they end up consuming memory, disk space and sometimes causing bugs too (ie WSL2 #3649).Somewhat related to #3592
The text was updated successfully, but these errors were encountered: