Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GTK widgets are too large on high resolution MS Windows displays #3514

Closed
totaam opened this issue Apr 3, 2022 · 12 comments
Closed

GTK widgets are too large on high resolution MS Windows displays #3514

totaam opened this issue Apr 3, 2022 · 12 comments
Labels
bug Something isn't working client win32 MS Windows OS

Comments

@totaam
Copy link
Collaborator

totaam commented Apr 3, 2022

See #3482 (comment)
ie:
157152678-68063d00-d415-4f93-bd26-5049e006817f

@totaam
Copy link
Collaborator Author

totaam commented Apr 26, 2022

@bdklahn does this still happen with the beta builds and the patched dummy driver version 0.4.0? (see #56)

@bdklahn
Copy link

bdklahn commented Apr 28, 2022

@totaam I don't know . . . Is this the latest beta?

Xpra_Setup.exe 2022-04-17 12:59 105M

Capture

@totaam
Copy link
Collaborator Author

totaam commented Apr 28, 2022

Oops, that's now fixed. Sorry about that.
In any case, newer builds are unlikely to fix this since the server is not involved, right? You're just running Xpra_cmd and getting this gui?

@bdklahn
Copy link

bdklahn commented May 4, 2022

I just tried again with 4.4

https://xpra.org/beta/windows/Xpra-x86_64_Setup.exe

2022-05-03 12:41 110M
Xpra4 4
AboutXpraCapture

@totaam
Copy link
Collaborator Author

totaam commented Oct 13, 2022

According to GDK-Win32/4.0: Enable HiDPI support for Windows, the support for HiDPI displays is only available in GTK4.
And since we're unlikely to ever port to GTK4 #1977 (too much Waylandization and levelling down)

We explicitly disable GDK_SCALING to ensure that GTK gives us the actual window dimensions. I tried allowing us to override this environment variable, but since it only supports whole integers, I can only use it to make things bigger, not smaller.

And there are no plans to support fractional scaling beyond fonts: https://gitlab.gnome.org/GNOME/gtk/-/issues/4345#note_1344625
HiDPI Fractional_scaling is documented for Wayland / Xorg, but using gsettings. No idea how to do the same on MS Windows.
Support fractional scaling on windows would seem to indicate that GDK_WIN32_DISABLE_HIDPI=1 may help?
(we may need to disable HiDPI support in GTK because we force enable DPI awareness: #697)
@bdklahn does this make any difference?

set GDK_WIN32_DISABLE_HIDPI=1
Xpra_cmd gui

totaam added a commit that referenced this issue Oct 13, 2022
@totaam
Copy link
Collaborator Author

totaam commented Oct 13, 2022

As per the commit above, beta 5.0 builds r32110 and later will have GDK_WIN32_DISABLE_HIDPI=1 by default.
@bdklahn does that make things better or worse?

@bdklahn
Copy link

bdklahn commented Oct 20, 2022

Xpra-Python3-x86_64_Setup exe2022-10-18 09_59

totaam added a commit that referenced this issue Oct 20, 2022
@totaam
Copy link
Collaborator Author

totaam commented Oct 20, 2022

Doh! I was still running with the env var set manually, which you can also do:

set GDK_WIN32_DISABLE_HIDPI=1
xpra_cmd attach ...

(the commit above fixes that - new builds will arrive shortly)

@totaam
Copy link
Collaborator Author

totaam commented Dec 3, 2022

@bdklahn did that help?

@totaam
Copy link
Collaborator Author

totaam commented Aug 15, 2023

Not heard back.

@totaam
Copy link
Collaborator Author

totaam commented Jan 30, 2024

@bdklahn the commit above and #3943 may help with this.
Please try 6.0-r35043 or later.

@totaam
Copy link
Collaborator Author

totaam commented Jul 10, 2024

FWIW: the icons in the header bar are no longer squished as of 391ae4d.

As for the buttons, they're big but everything is when setting "200% scaling" - so I'm not sure what the problem is / was.
I guess it would be nice to override the size of the icons used for minimize / maximize / close, but that's an internal GTK thing AFAIK.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working client win32 MS Windows OS
Projects
None yet
Development

No branches or pull requests

2 participants