-
-
Notifications
You must be signed in to change notification settings - Fork 171
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
modularize client authentication handlers #1796
Comments
See also #1861 |
At the moment, the The other handlers behave differently... for some this doesn't matter too much (ie: prompt), but for others this prevents other modules from being tried (ie: file, env, etc) |
Done in r22711 + r22713 + r22714 + r22715. All the authentication handlers now live in Examples:
PASSWORD1=foo PASSWORD2=bar \
xpra attach tcp://192.168.1.7:10000 \
-d auth \
--challenge-handlers=env:name=PASSWORD1 \
--challenge-handlers=env:name=PASSWORD2
xpra attach tcp://192.168.1.7:10000 -d auth \
--challenge-handlers=file,filename=pass.txt |
The same way this was done for the server modules. The modules can then be configured more easily using the
challenge-handlers
string.Making it easier to test and to implement new ones (ie: "exec" handler which calls an external binary)
We can also define a clearer interface so modules can claim a particular challenge mode, or be used as fallback.
The text was updated successfully, but these errors were encountered: