Skip to content

Commit

Permalink
#2834 switch to Xvfb on Debian and Ubuntu
Browse files Browse the repository at this point in the history
git-svn-id: https://xpra.org/svn/Xpra/trunk@27165 3bb7dfac-3a0b-4e04-842a-767bc560f471
  • Loading branch information
totaam committed Aug 15, 2020
1 parent dd8d241 commit 6fbc11a
Show file tree
Hide file tree
Showing 3 changed files with 8 additions and 5 deletions.
5 changes: 2 additions & 3 deletions debian/control
Original file line number Diff line number Diff line change
Expand Up @@ -73,9 +73,8 @@ Depends: ${misc:Depends}, ${python3:Depends}, ${shlibs:Depends}
,python3-lz4
# clipboard packet compression:
,python3-brotli
#we need a vfb: either Xdummy (Debian) or Xvfb (some Ubuntu versions break Xorg tty access)
#install both so users can choose which one they want to use:
,xserver-xorg-video-dummy | xserver-xorg-video-dummy-hwe
#we need a vfb: either Xdummy or Xvfb
# ,xserver-xorg-video-dummy | xserver-xorg-video-dummy-hwe
,xvfb
,keyboard-configuration
# fast JPEG client support:
Expand Down
2 changes: 1 addition & 1 deletion debian/rules
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
#stretch:export DEB_BUILD_MAINT_OPTIONS=hardening=+all
#buster:export DEB_BUILD_MAINT_OPTIONS=hardening=+all

BUILDOPTS= --with-Xdummy --without-Xdummy_wrapper --pkg-config-path=/usr/lib/xpra/pkgconfig --rpath=/usr/lib/xpra/
BUILDOPTS= --without-Xdummy --without-Xdummy_wrapper --pkg-config-path=/usr/lib/xpra/pkgconfig --rpath=/usr/lib/xpra/

%:
dh $@ --with python3 --with systemd
Expand Down
6 changes: 5 additions & 1 deletion src/xpra/scripts/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@
from xpra.os_util import (
WIN32, OSX, POSIX,
osexpand, getuid, getgid, get_username_for_uid,
is_Debian, is_arm,
is_Debian, is_Ubuntu, is_arm,
)

def warn(msg):
Expand Down Expand Up @@ -134,6 +134,10 @@ def detect_xvfb_command(conf_dir="/etc/xpra/", bin_dir=None,
if is_arm():
#arm struggles to launch Xdummy, so use Xvfb:
return get_Xvfb_command()
if is_Ubuntu() or is_Debian():
#These distros do weird things and this can cause the real X11 server to crash
#see ticket #2834
return get_Xvfb_command()

xorg_bin = get_xorg_bin()
def Xorg_suid_check():
Expand Down

0 comments on commit 6fbc11a

Please sign in to comment.