-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clipboard images with html5 client #71
Comments
More pointers:
Raising Xpra-org/xpra#1844. |
As per Chrome Platform Status: Asynchronous Clipboard API: Support for images and other data types is still under development. |
MDN: Clipboard: only Firefox has support for |
Firefox only: clipboard.setImageData The image is provided as an ArrayBuffer containing the encoded image. JPEG and PNG formats are supported. Chrome: chrome.clipboard |
The image API is now available in chrome beta: https://bugs.chromium.org/p/chromium/issues/detail?id=150835#c118 |
2019-06-04 16:28:06: antoine uploaded file
|
2019-06-04 16:34:59: antoine uploaded file
|
The patch above almost works, but there is a problem with chrome: the tabs crash... reproducer in [/attachment/ticket/2312/clipboard.html]. With the new It would be useful to collect the list of mimetypes we can get from the async API so we can handle them properly rather than assuming we just get UTF8 for text and Related links:
|
Merged the image transfer clipboard code (disabled by default) in r22857. |
chrome bug reported here: clipboard.write can crash the tab |
They claim that the bug has been fixed, but it's still present in the latest beta builds. Also, the png data from the example I have given is clearly valid, so it should not be throwing a |
2019-07-26 06:16:05: antoine uploaded file
|
Updates:
Tested by:
Things to consider:
@afarr: this should be of interest to you |
2019-09-19 20:54:13: afarr commented
|
Does it work if you enable the experimental features as per comment:6? |
Warning: see Xpra-org/xpra#1844 comment:13 (Firefox is a no go, IE / MS Edge use the legacy code) |
2019-10-24 23:19:52: afarr commented
|
That's an unlucky coincidence, there was a regression in r24231, fixed in r24247. See Xpra-org/xpra#2461 The 3.0.1 builds had been fixed, the 4.0 beta builds had not.. |
2019-10-29 22:10:31: afarr commented
|
2019-10-29 22:27:04: afarr commented
|
I tried it with a Fedora 31 client and it worked perfectly on the first attempt (not something that happens every day!):
Here's what the debug log shows ("clipboard" debugging enabled on the connect.html page):
Then I tried it on win7... and nothing!? Note: your browser is likely to ask you about allowing xpra to access the clipboard. If you somehow refuse, it won't ask again and things just won't work from then on... I'm not saying that this is the case here, just something to be aware of. You can verify that the client's browser has support for copying images on the server using:
|
2019-11-12 22:42:46: afarr commented
|
2019-11-13 17:30:22: antoine commented
|
2019-11-20 23:46:34: afarr commented
|
Let's close this. |
2020-05-29 07:53:10: antoine commented
|
We want to transfer the pixel data as
image/png
and set it as best we can usingsetData
or newer methods (#1844).See THE DEFINITIVE GUIDE TO COPYING AND PASTING IN JAVASCRIPT
The difficulty here is that because the html5 clibpoard is greedy, we need to choose png as soon as we get the clipboard event so we can send the binary data with the token.
Some pointers in Xpra-org/xpra#812#comment:29
The text was updated successfully, but these errors were encountered: