Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seeing an error in expire_delayed_region, in window_source.py, when mousing over browser regions #2463

Closed
totaam opened this issue Oct 24, 2019 · 3 comments

Comments

@totaam
Copy link
Collaborator

totaam commented Oct 24, 2019

Issue migrated from trac ticket # 2463

component: html5 | priority: major | resolution: fixed

2019-10-24 22:28:09: afarr created the issue


Updated fedora 30 server to 4.0-24232 and launched with

xpra start :13 --no-daemon --bind-tcp=0.0.0.0:1234 --bind-ws=0.0.0.0:1237 --start-child=xterm --start-child=xterm --exit-with-children

Connected with a Windows 7 html5 client (Chrome 77), and installed chromium (since firefox seems to be problematic?) on the server.

The interaction periodically froze... and then I noticed the following traceback recurring with the regularity that you will probably expect.

Traceback (most recent call last):
  File "/usr/lib64/python3.7/site-packages/xpra/server/window/window_source.py", line 1447, in expire_delayed_region
    self.may_send_delayed()
  File "/usr/lib64/python3.7/site-packages/xpra/server/window/window_source.py", line 1611, in may_send_delayed
    self.do_send_delayed()
  File "/usr/lib64/python3.7/site-packages/xpra/server/window/window_source.py", line 1622, in do_send_delayed
    self.send_delayed_regions(delayed)
  File "/usr/lib64/python3.7/site-packages/xpra/server/window/window_source.py", line 1640, in send_delayed_regions
    self.do_send_delayed_regions(dr.damage_time, dr.regions, dr.encoding, dr.options)
  File "/usr/lib64/python3.7/site-packages/xpra/server/window/window_video_source.py", line 810, in do_send_delayed_regions
    send_nonvideo(regions=regions, encoding=None, exclude_region=actual_vr)
  File "/usr/lib64/python3.7/site-packages/xpra/server/window/window_video_source.py", line 710, in send_nonvideo
    super().do_send_delayed_regions(damage_time, regions, encoding, options, exclude_region=exclude_region, get_best_encoding=get_best_encoding)
TypeError: super(type, obj): obj must be an instance or subtype of type

I was able to trigger when mousing over regions (probably triggering nonvideo region repaints?...) of chromium or firefox, but not in applications like xterm or gedit.

Running videos don't trigger, but it looks like keyboard input also triggers it, and those typed characters are often not rendering as the error is triggered when typing into browser fields.

@totaam
Copy link
Collaborator Author

totaam commented Oct 25, 2019

2019-10-25 01:54:48: antoine changed status from new to closed

@totaam
Copy link
Collaborator Author

totaam commented Oct 25, 2019

2019-10-25 01:54:48: antoine set resolution to fixed

@totaam
Copy link
Collaborator Author

totaam commented Oct 25, 2019

2019-10-25 01:54:48: antoine commented


Good catch, that was caused by r24174 and is fixed in r24259.

There may be more, so I'll inspect the changeset again.

@totaam totaam closed this as completed Oct 25, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant