Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made this work without the need for Oracle JDK #514

Merged
merged 1 commit into from
Mar 28, 2020

Conversation

Webbeh
Copy link
Contributor

@Webbeh Webbeh commented Mar 28, 2020

Removed the need for ALL linux users to download the crappy Oracle JDK. Quark now works with any JRE you want.

Please refrain from using any "com.sun.***" package in the future, as they're oracle-specific and usually really outdated.

@XorTroll
Copy link
Owner

Thanks for the advice, merging this

@XorTroll XorTroll merged commit 641010b into XorTroll:master Mar 28, 2020
@Webbeh
Copy link
Contributor Author

Webbeh commented Mar 28, 2020

I don't have any Windows computer nearby. It should work in theory, but can you make sure it is working ?

I am using it as we speak on Linux and it works well.

By the way, I had GoldLeaf 0.7.3 installed and it didn't show me the "outdated" error, but the "doesn't seem to be goldleaf" error instead.

@XorTroll
Copy link
Owner

Actually, now that I think of it, checking just for "win" wouldn't be a problem for Darwin?

@Webbeh
Copy link
Contributor Author

Webbeh commented Mar 28, 2020

I'm pretty sure it shouldn't be a problem, but otherwise we can just change for "windows" instead of "win".

http://lopica.sourceforge.net/os.html

@Webbeh
Copy link
Contributor Author

Webbeh commented Mar 28, 2020

So I just tested in a virtual Mac and it is detected as "Home:". It works on Mac OS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants