feat: add default mac menu bar items #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add default 'Window' menu - Add help menu with links to github issues and wiki Closes Xiphe#83
|
Cool! Thanks for the PR. (And also sorry for not really working on this lately :/) |
|
the release did not went through :/ Will look into that within the next days |
|
I checked the build log and noticed that I faced the same issue locally when packaging a build. I traced it down to an incompatibility between ts-loader and webpack (see TypeStrong/ts-loader#595). By updating CRA to the next version (see facebook/create-react-app#11278) it was fixed. I did not commit these changes because I thought it is a local issue and I don't know if updating CRA has any side effects. |
|
Ah awesome! Thanks for sharing. Will try that later today |
|
🎉 This PR is included in version 1.0.0-beta.18 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #83