dp_rx/data/dp_rx.tcl: unbreak vid_phy direction #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Commit edb1f97 (vid_phy_ctrl:hdmi_gt_ctrl: Generate Channels only if connected to DP/HDMI) broke the vid_phy direction setting as it set the 4th cell to 1 instead of 0. As specified by the binding, the 4th cell encodes the phy directions: direction_tx = 0 for RX and 1 for TX https://github.com/Xilinx/dp-modules/blob/xlnx_rel_v2024.1/Documentation/devicetree/bindings/xlnx%2Cvphy.txt So setting it to 1 doesn't make any sense for the DP receiver core. This seems to be a cut'n'paste mistake from the similar logic in the DP transmitter core. Fixes: edb1f97 ("vid_phy_ctrl:hdmi_gt_ctrl: Generate Channels only if connected to DP/HDMI") Signed-off-by: Peter Korsgaard <[email protected]>
|
Hi @jacmet |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit edb1f97 (vid_phy_ctrl:hdmi_gt_ctrl: Generate Channels only if connected to DP/HDMI) broke the vid_phy direction setting as it set the 4th cell to 1 instead of 0.
As specified by the binding, the 4th cell encodes the phy directions:
direction_tx = 0 for RX and 1 for TX
https://github.com/Xilinx/dp-modules/blob/xlnx_rel_v2024.1/Documentation/devicetree/bindings/xlnx%2Cvphy.txt
So setting it to 1 doesn't make any sense for the DP receiver core. This seems to be a cut'n'paste mistake from the similar logic in the DP transmitter core.
Fixes: edb1f97 ("vid_phy_ctrl:hdmi_gt_ctrl: Generate Channels only if connected to DP/HDMI")