Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GS/embedded: update SD mount path; remove XILINX_XRT env setup #268

Merged
merged 2 commits into from
Aug 4, 2022
Merged

GS/embedded: update SD mount path; remove XILINX_XRT env setup #268

merged 2 commits into from
Aug 4, 2022

Conversation

imrickysu
Copy link
Contributor

  • PetaLinux common image updated the SD card auto mount path to /run/media/mmcblk0p1
  • XRT doesn't require XILINX_XRT on embedded acceleration use cases.

@imrickysu imrickysu requested a review from randyh62 July 7, 2022 03:36
@imrickysu
Copy link
Contributor Author

Hi Randy, I updated the Getting Started tutorial for these two issues. Please check.

randyh62
randyh62 approved these changes Jul 7, 2022
View reviewed changes
Copy link
Contributor

@randyh62 randyh62 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi Ricky, do you want to also change the run_sw_emu.sh, run_hw_emu.sh, and run_hw.sh? I tested this in 2022.1 and the change does not appear to be required, as it still runs, but perhaps for consistency we should change the run scripts as well?
Thanks,
Randy

@imrickysu
Copy link
Contributor Author

Hi @randyh62 , I removed XILINX_XRT and XILINX_VITIS env setup in run_*.sh.
I didn't touch the mount commands though they have different mount destination than the default PetaLinux mount location. The commands are expected to work because it mounts manually. It doesn't depend on auto mount paths.

@imrickysu imrickysu merged commit aaaf045 into Xilinx:2022.1 Aug 4, 2022
imrickysu added a commit that referenced this pull request Nov 3, 2022
@imrickysu
GS/embedded: update SD mount path; remove XILINX_XRT env setup (#268)
147c1a9 
* GS/embedded: update SD mount path; remove XILINX_XRT env setup

* Remove XILINX_XRT env setup for embedded application run time
CRTejaswi pushed a commit to CRTejaswi/amd-vitis that referenced this pull request Oct 3, 2023
Squashed 'data_analytics' changes from 6cc8367~10..6cc8367 (Xilinx#428)
090fb7d 
6cc8367 fix routing (Xilinx#270)
fb56cab fix time (Xilinx#269)
69f3175 replace -lpthread with -pthread (Xilinx#268)
0116abe Disable old shell will DMA issues (Xilinx#266)
654c2b1 fix hw_emu fail (Xilinx#267)
96b0e1a Merge pull request Xilinx#259 from xingw/regRex-sc
b662ce6 Port to U50, optimzed the performance
2d4476f fix typo error
26b79f8 update release notes
67607a7 update internals.rst
66de365 add csvParser.rst to upper level rst
92bbf07 Remove the hard vpp_sc.mk
6b71832 Enlarge the maximum build time&memory
7dd0e7e Add return Errcode
b40dd31 Add <build> target
8485b3c Update the vpp_sc.mk version
d616073 Add the include directory for SC
dcfaa5e Add SC implementation for Regex L3

Co-authored-by: sdausr <[email protected]>
CRTejaswi pushed a commit to CRTejaswi/amd-vitis that referenced this pull request Oct 3, 2023
Squashed 'utils' changes from 698eb8e..9fb2945 (#705)
d031f49 
9fb2945 remove HOST_ARCH from docs (Xilinx#279)
8dc4ec3 Merge pull request Xilinx#278 from FaaSApps/cr_1135044_1
d440a75 fix description.json for cuboid_read_hls and cuboid_write_hls
17c5fb0 Merge pull request Xilinx#277 from FaaSApps/cr_1135044
d50704a remove unsupported properties
6b83ed6 Merge pull request Xilinx#276 from FaaSApps/fix_4d_2
96e8661 fix cosim error caused by stack size
ac90d72 Merge pull request Xilinx#275 from FaaSApps/fix_4d
b227e8a fix 4d datamover
cc84882 Clean unused files from docs in next branch (Xilinx#274)
be607f4 fix bug in doc -- remove build dir and update index.rst (Xilinx#273)
6161a00 add mem (Xilinx#272)
d8fa6fa build rst and html
79230a9 fix doc (Xilinx#271)
5a49d7f Merge pull request Xilinx#270 from tuol/2022.2_features
6a534d9 add datamover L1 tests
017c789 update doc in next branch for portal (Xilinx#269)
596d99d Merge pull request Xilinx#268 from liyuanz/next
91996c3 update
3371605 Merge pull request Xilinx#266 from changg/22.1_mks
8fc7d8a fix u280 case
9710bb4 22.2 update mk
1b0c33d change 2022.1_stable_latest to 2022.2_stable_latest
2301ab6 Merge pull request Xilinx#263 from tuol/fix_tutorial
b1b1c22 remove fix platform in tutorial
03797e0 Merge pull request Xilinx#262 from tuol/fix_ttl
38e737d fix ttl
472feb6 Merge pull request Xilinx#260 from tuol/fix_conf_py
0bfb2be update version in conf.py

Co-authored-by: sdausr <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@randyh62 randyh62 randyh62 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imrickysu @randyh62