Merge branch 'develop' of https://github.com/oppia/oppia-android into o…

…ppia#3843

app/BUILD.bazel

@@ -660,7 +660,6 @@ kt_android_library(
         "//third_party:androidx_core_core-ktx",
         "//third_party:androidx_databinding_databinding-common",
         "//third_party:androidx_databinding_databinding-runtime",
-        "//third_party:androidx_fragment_fragment",
         "//third_party:circularimageview_circular_image_view",
         "//utility/src/main/java/org/oppia/android/util/accessibility",
         "//utility/src/main/java/org/oppia/android/util/parser/html:html_parser",

app/src/main/java/org/oppia/android/app/administratorcontrols/AdministratorControlsActivityPresenter.kt

@@ -96,7 +96,7 @@ class AdministratorControlsActivityPresenter @Inject constructor(
       .findFragmentById(
         R.id.administrator_controls_activity_fragment_navigation_drawer
       ) as NavigationDrawerFragment
-    navigationDrawerFragment.initializeDrawer(
+    navigationDrawerFragment.setUpDrawer(
       binding.administratorControlsActivityDrawerLayout,
       toolbar, /* menuItemId= */ 0
     )

app/src/main/java/org/oppia/android/app/customview/interaction/FractionInputInteractionView.kt

@@ -8,7 +8,7 @@ import android.view.KeyEvent.ACTION_UP
 import android.view.KeyEvent.KEYCODE_BACK
 import android.view.View
 import android.view.inputmethod.EditorInfo
-import androidx.appcompat.widget.AppCompatEditText
+import android.widget.EditText
 import org.oppia.android.app.player.state.listener.StateKeyboardButtonListener
 import org.oppia.android.app.utility.KeyboardHelper.Companion.hideSoftKeyboard
 import org.oppia.android.app.utility.KeyboardHelper.Companion.showSoftKeyboard
@@ -22,12 +22,12 @@ import org.oppia.android.app.utility.KeyboardHelper.Companion.showSoftKeyboard
 
 // TODO(#4135): Add a dedicated test suite for this class.
 
-/** The custom [AppCompatEditText] class for fraction input interaction view. */
+/** The custom EditText class for fraction input interaction view. */
 class FractionInputInteractionView @JvmOverloads constructor(
   context: Context,
   attrs: AttributeSet? = null,
   defStyle: Int = android.R.attr.editTextStyle
-) : AppCompatEditText(context, attrs, defStyle), View.OnFocusChangeListener {
+) : EditText(context, attrs, defStyle), View.OnFocusChangeListener {
   private var hintText: CharSequence = ""
   private val stateKeyboardButtonListener: StateKeyboardButtonListener
 
@@ -71,7 +71,7 @@ class FractionInputInteractionView @JvmOverloads constructor(
 
   private fun restoreHint() {
     hint = hintText
-    if (text?.isEmpty() == true) setTypeface(typeface, Typeface.ITALIC)
+    if (text.isEmpty()) setTypeface(typeface, Typeface.ITALIC)
     setSingleLine(false)
   }
 }

app/src/main/java/org/oppia/android/app/customview/interaction/MathExpressionInteractionsView.kt

@@ -6,7 +6,7 @@ import android.util.AttributeSet
 import android.view.KeyEvent
 import android.view.View
 import android.view.inputmethod.EditorInfo
-import androidx.appcompat.widget.AppCompatEditText
+import android.widget.EditText
 import org.oppia.android.app.player.state.listener.StateKeyboardButtonListener
 import org.oppia.android.app.utility.KeyboardHelper.Companion.hideSoftKeyboard
 import org.oppia.android.app.utility.KeyboardHelper.Companion.showSoftKeyboard
@@ -19,7 +19,7 @@ import org.oppia.android.app.utility.KeyboardHelper.Companion.showSoftKeyboard
 //  maxLength="200".
 
 /**
- * The custom [AppCompatEditText] class for math expression interactions interaction view.
+ * The custom [EditText] class for math expression interactions interaction view.
  *
  * Note that the hint should be set via [setPlaceholder] to ensure that it's properly initialized if
  * using databinding, otherwise setting the hint through android:hint should work fine.
@@ -28,7 +28,7 @@ class MathExpressionInteractionsView @JvmOverloads constructor(
   context: Context,
   attrs: AttributeSet? = null,
   defStyle: Int = android.R.attr.editTextStyle
-) : AppCompatEditText(context, attrs, defStyle), View.OnFocusChangeListener {
+) : EditText(context, attrs, defStyle), View.OnFocusChangeListener {
   private var hintText: CharSequence = ""
   private val stateKeyboardButtonListener: StateKeyboardButtonListener
 
@@ -84,7 +84,7 @@ class MathExpressionInteractionsView @JvmOverloads constructor(
 
   private fun restoreHint() {
     hint = hintText
-    if (text?.isEmpty() == true) setTypeface(typeface, Typeface.ITALIC)
+    if (text.isEmpty()) setTypeface(typeface, Typeface.ITALIC)
     setSingleLine(false)
   }
 }

app/src/main/java/org/oppia/android/app/customview/interaction/NumericInputInteractionView.kt

@@ -8,7 +8,7 @@ import android.view.KeyEvent.ACTION_UP
 import android.view.KeyEvent.KEYCODE_BACK
 import android.view.View
 import android.view.inputmethod.EditorInfo
-import androidx.appcompat.widget.AppCompatEditText
+import android.widget.EditText
 import org.oppia.android.app.player.state.listener.StateKeyboardButtonListener
 import org.oppia.android.app.utility.KeyboardHelper.Companion.hideSoftKeyboard
 import org.oppia.android.app.utility.KeyboardHelper.Companion.showSoftKeyboard
@@ -20,12 +20,12 @@ import org.oppia.android.app.utility.KeyboardHelper.Companion.showSoftKeyboard
 //  background="@drawable/edit_text_background"
 //  maxLength="200".
 
-/** The custom [AppCompatEditText] class for numeric input interaction view. */
+/** The custom EditText class for numeric input interaction view. */
 class NumericInputInteractionView @JvmOverloads constructor(
   context: Context,
   attrs: AttributeSet? = null,
   defStyle: Int = android.R.attr.editTextStyle
-) : AppCompatEditText(context, attrs, defStyle), View.OnFocusChangeListener {
+) : EditText(context, attrs, defStyle), View.OnFocusChangeListener {
   private val stateKeyboardButtonListener: StateKeyboardButtonListener
   private var hintText: CharSequence = ""
 
@@ -69,7 +69,7 @@ class NumericInputInteractionView @JvmOverloads constructor(
 
   private fun restoreHint() {
     hint = hintText
-    if (text?.isEmpty() == true) setTypeface(typeface, Typeface.ITALIC)
+    if (text.isEmpty()) setTypeface(typeface, Typeface.ITALIC)
     setSingleLine(false)
   }
 }

app/src/main/java/org/oppia/android/app/customview/interaction/RatioInputInteractionView.kt

@@ -6,16 +6,16 @@ import android.util.AttributeSet
 import android.view.KeyEvent
 import android.view.View
 import android.view.inputmethod.EditorInfo
-import androidx.appcompat.widget.AppCompatEditText
+import android.widget.EditText
 import org.oppia.android.app.player.state.listener.StateKeyboardButtonListener
 import org.oppia.android.app.utility.KeyboardHelper
 
-/** The custom [AppCompatEditText] class for ratio input interaction view. */
+/** The custom EditText class for ratio input interaction view. */
 class RatioInputInteractionView @JvmOverloads constructor(
   context: Context,
   attrs: AttributeSet? = null,
   defStyle: Int = android.R.attr.editTextStyle
-) : AppCompatEditText(context, attrs, defStyle), View.OnFocusChangeListener {
+) : EditText(context, attrs, defStyle), View.OnFocusChangeListener {
   private var hintText: CharSequence = ""
   private val stateKeyboardButtonListener: StateKeyboardButtonListener
 
@@ -59,7 +59,7 @@ class RatioInputInteractionView @JvmOverloads constructor(
 
   private fun restoreHint() {
     hint = hintText
-    if (text?.isEmpty() == true) setTypeface(typeface, Typeface.ITALIC)
+    if (text.isEmpty()) setTypeface(typeface, Typeface.ITALIC)
     setSingleLine(false)
   }
 }

app/src/main/java/org/oppia/android/app/customview/interaction/TextInputInteractionView.kt

@@ -6,7 +6,7 @@ import android.util.AttributeSet
 import android.view.KeyEvent
 import android.view.View
 import android.view.inputmethod.EditorInfo
-import androidx.appcompat.widget.AppCompatEditText
+import android.widget.EditText
 import org.oppia.android.app.player.state.listener.StateKeyboardButtonListener
 import org.oppia.android.app.utility.KeyboardHelper.Companion.hideSoftKeyboard
 import org.oppia.android.app.utility.KeyboardHelper.Companion.showSoftKeyboard
@@ -17,12 +17,12 @@ import org.oppia.android.app.utility.KeyboardHelper.Companion.showSoftKeyboard
 //  background="@drawable/edit_text_background"
 //  maxLength="200".
 
-/** The custom [AppCompatEditText] class for text input interaction view. */
+/** The custom EditText class for text input interaction view. */
 class TextInputInteractionView @JvmOverloads constructor(
   context: Context,
   attrs: AttributeSet? = null,
   defStyle: Int = android.R.attr.editTextStyle
-) : AppCompatEditText(context, attrs, defStyle), View.OnFocusChangeListener {
+) : EditText(context, attrs, defStyle), View.OnFocusChangeListener {
   private var hintText: CharSequence = ""
   private val stateKeyboardButtonListener: StateKeyboardButtonListener
 
@@ -66,7 +66,7 @@ class TextInputInteractionView @JvmOverloads constructor(
 
   private fun restoreHint() {
     hint = hintText
-    if (text?.isEmpty() == true) setTypeface(typeface, Typeface.ITALIC)
-    isSingleLine = false
+    if (text.isEmpty()) setTypeface(typeface, Typeface.ITALIC)
+    setSingleLine(false)
   }
 }

app/src/main/java/org/oppia/android/app/devoptions/DeveloperOptionsActivityPresenter.kt

@@ -41,7 +41,7 @@ class DeveloperOptionsActivityPresenter @Inject constructor(
       .findFragmentById(
         R.id.developer_options_activity_fragment_navigation_drawer
       ) as NavigationDrawerFragment
-    navigationDrawerFragment.initializeDrawer(
+    navigationDrawerFragment.setUpDrawer(
       binding.developerOptionsActivityDrawerLayout,
       toolbar, menuItemId = -1
     )

app/src/main/java/org/oppia/android/app/drawer/NavigationDrawerFragment.kt

@@ -33,8 +33,8 @@ class NavigationDrawerFragment :
     return navigationDrawerFragmentPresenter.handleCreateView(inflater, container)
   }
 
-  fun initializeDrawer(drawerLayout: DrawerLayout, toolbar: Toolbar, menuItemId: Int) {
-    navigationDrawerFragmentPresenter.initializeDrawer(drawerLayout, toolbar, menuItemId)
+  fun setUpDrawer(drawerLayout: DrawerLayout, toolbar: Toolbar, menuItemId: Int) {
+    navigationDrawerFragmentPresenter.setUpDrawer(drawerLayout, toolbar, menuItemId)
   }
 
   override fun routeToProfileProgress(profileId: Int) {

app/src/main/java/org/oppia/android/app/drawer/NavigationDrawerFragmentPresenter.kt

@@ -62,17 +62,13 @@ class NavigationDrawerFragmentPresenter @Inject constructor(
   private lateinit var drawerLayout: DrawerLayout
   private lateinit var binding: DrawerFragmentBinding
   private lateinit var profileId: ProfileId
-  private lateinit var toolbar: Toolbar
   private var previousMenuItemId: Int? = null
   private var internalProfileId: Int = -1
-  private var menuItemId: Int = 0
 
   fun handleCreateView(inflater: LayoutInflater, container: ViewGroup?): View? {
     binding = DrawerFragmentBinding.inflate(inflater, container, /* attachToRoot= */ false)
     binding.fragmentDrawerNavView.setNavigationItemSelectedListener(this)
 
-    setUpDrawer(drawerLayout, toolbar, menuItemId)
-
     fragment.setHasOptionsMenu(true)
 
     internalProfileId = activity.intent.getIntExtra(NAVIGATION_PROFILE_ID_ARGUMENT_KEY, -1)
@@ -370,32 +366,11 @@ class NavigationDrawerFragmentPresenter @Inject constructor(
     }
   }
 
-  fun initializeDrawer(drawerLayout: DrawerLayout, toolbar: Toolbar, menuItemId: Int) {
-    this.drawerLayout = drawerLayout
-    this.toolbar = toolbar
-    this.menuItemId = menuItemId
-
-    /**
-     * [setUpDrawer] is called directly if binding is already initialized.
-     * Otherwise, [setUpDrawer] is called from [handleCreateView].
-     *
-     * Note: [binding] is already initialized when [initializeDrawer] is called via [onRestart]
-     * and [handleCreateView] will not be called in that case.
-     */
-    if (this::binding.isInitialized) {
-      setUpDrawer(
-        this.drawerLayout,
-        this.toolbar,
-        this.menuItemId
-      )
-    }
-  }
-
   /**
    * Initializes the navigation drawer for the specified [DrawerLayout] and [Toolbar], which the host activity is
    * expected to provide. The [menuItemId] corresponds to the menu ID of the current activity, for navigation purposes.
    */
-  private fun setUpDrawer(drawerLayout: DrawerLayout, toolbar: Toolbar, menuItemId: Int) {
+  fun setUpDrawer(drawerLayout: DrawerLayout, toolbar: Toolbar, menuItemId: Int) {
     previousMenuItemId = if (activity is TopicActivity) null else menuItemId
     if (menuItemId != 0 && menuItemId != -1) {
       getFooterViewModel().isAdministratorControlsSelected.set(false)
@@ -432,6 +407,7 @@ class NavigationDrawerFragmentPresenter @Inject constructor(
             true
         }
       }
+      this.drawerLayout = drawerLayout
       drawerToggle = object : ActionBarDrawerToggle(
         fragment.activity,
         drawerLayout,
@@ -470,6 +446,7 @@ class NavigationDrawerFragmentPresenter @Inject constructor(
       // For showing navigation drawer in DeveloperOptionsActivity
       else if (menuItemId == -1) getFooterViewModel().isDeveloperOptionsSelected.set(true)
       uncheckAllMenuItemsWhenAdministratorControlsOrDeveloperOptionsIsSelected()
+      this.drawerLayout = drawerLayout
       drawerToggle = object : ActionBarDrawerToggle(
         fragment.activity,
         drawerLayout,

app/src/main/java/org/oppia/android/app/help/HelpActivityPresenter.kt

@@ -192,7 +192,7 @@ class HelpActivityPresenter @Inject constructor(
       .findFragmentById(
         R.id.help_activity_fragment_navigation_drawer
       ) as NavigationDrawerFragment
-    navigationDrawerFragment.initializeDrawer(
+    navigationDrawerFragment.setUpDrawer(
       activity.findViewById<View>(R.id.help_activity_drawer_layout) as DrawerLayout,
       toolbar, R.id.nav_help
     )

app/src/main/java/org/oppia/android/app/home/HomeActivityPresenter.kt

@@ -49,7 +49,7 @@ class HomeActivityPresenter @Inject constructor(private val activity: AppCompatA
     navigationDrawerFragment = activity
       .supportFragmentManager
       .findFragmentById(R.id.home_activity_fragment_navigation_drawer) as NavigationDrawerFragment
-    navigationDrawerFragment!!.initializeDrawer(
+    navigationDrawerFragment!!.setUpDrawer(
       activity.findViewById<View>(R.id.home_activity_drawer_layout) as DrawerLayout,
       toolbar, R.id.nav_home
     )

app/src/main/java/org/oppia/android/app/options/OptionControlsViewModel.kt

@@ -18,8 +18,6 @@ import org.oppia.android.util.data.AsyncResult
 import org.oppia.android.util.data.DataProvider
 import org.oppia.android.util.data.DataProviders.Companion.combineWith
 import org.oppia.android.util.data.DataProviders.Companion.toLiveData
-import org.oppia.android.util.platformparameter.EnableLanguageSelectionUi
-import org.oppia.android.util.platformparameter.PlatformParameterValue
 import javax.inject.Inject
 
 /** [ViewModel] for [OptionsFragment]. */
@@ -32,7 +30,6 @@ class OptionControlsViewModel @Inject constructor(
   activity: AppCompatActivity,
   private val profileManagementController: ProfileManagementController,
   private val oppiaLogger: OppiaLogger,
-  @EnableLanguageSelectionUi private val enableLanguageSelectionUi: PlatformParameterValue<Boolean>,
   private val resourceHandler: AppLanguageResourceHandler,
   private val translationController: TranslationController
 ) : OptionsItemViewModel() {
@@ -112,13 +109,12 @@ class OptionControlsViewModel @Inject constructor(
   }
 
   private fun createAppLanguageViewModel(language: OppiaLanguage): OptionsAppLanguageViewModel? {
-    return if (enableLanguageSelectionUi.value) {
-      OptionsAppLanguageViewModel(
-        routeToAppLanguageListListener,
-        loadAppLanguageListListener, language,
-        resourceHandler.computeLocalizedDisplayName(language)
-      )
-    } else null
+    return OptionsAppLanguageViewModel(
+      routeToAppLanguageListListener,
+      loadAppLanguageListListener,
+      language,
+      resourceHandler.computeLocalizedDisplayName(language)
+    )
   }
 
   private fun createAudioLanguageViewModel(profile: Profile): OptionsAudioLanguageViewModel {

app/src/main/java/org/oppia/android/app/options/OptionsActivityPresenter.kt

@@ -72,7 +72,7 @@ class OptionsActivityPresenter @Inject constructor(
       .findFragmentById(
         R.id.options_activity_fragment_navigation_drawer
       ) as NavigationDrawerFragment
-    navigationDrawerFragment!!.initializeDrawer(
+    navigationDrawerFragment!!.setUpDrawer(
       activity.findViewById<View>(R.id.options_activity_drawer_layout) as DrawerLayout,
       toolbar, R.id.nav_options
     )

app/src/main/res/layout-sw600dp/administrator_controls_activity.xml

@@ -98,7 +98,7 @@
         app:layout_constraintTop_toBottomOf="@id/administrator_controls_activity_toolbar" />
     </androidx.constraintlayout.widget.ConstraintLayout>
 
-    <androidx.fragment.app.FragmentContainerView
+    <fragment
       android:id="@+id/administrator_controls_activity_fragment_navigation_drawer"
       android:name="org.oppia.android.app.drawer.NavigationDrawerFragment"
       android:layout_width="@dimen/navigation_drawer_width"

app/src/main/res/layout-sw600dp/help_activity.xml

@@ -102,7 +102,7 @@
     </androidx.constraintlayout.widget.ConstraintLayout>
   </LinearLayout>
 
-  <androidx.fragment.app.FragmentContainerView
+  <fragment
     android:id="@+id/help_activity_fragment_navigation_drawer"
     android:name="org.oppia.android.app.drawer.NavigationDrawerFragment"
     android:layout_width="wrap_content"

app/src/main/res/layout-sw600dp/option_activity.xml

@@ -85,7 +85,7 @@
     </androidx.constraintlayout.widget.ConstraintLayout>
   </LinearLayout>
 
-  <androidx.fragment.app.FragmentContainerView
+  <fragment
     android:id="@+id/options_activity_fragment_navigation_drawer"
     android:name="org.oppia.android.app.drawer.NavigationDrawerFragment"
     android:layout_width="wrap_content"

app/src/main/res/layout-sw600dp/revision_card_fragment.xml

@@ -61,14 +61,13 @@
 
           <com.google.android.material.card.MaterialCardView
             android:id="@+id/previous_navigation_card"
-            android:layout_width="wrap_content"
+            android:layout_width="144dp"
             android:layout_height="wrap_content"
             android:layout_marginStart="28dp"
             android:layout_marginTop="16dp"
             android:layout_marginEnd="28dp"
             android:layout_marginBottom="@dimen/topic_revision_summary_view_container_margin_bottom"
             android:clipToPadding="true"
-            android:maxWidth="144dp"
             android:onClick="@{() -> viewModel.onPreviousCardClicked()}"
             android:visibility="@{viewModel.subtopicId == 1 ? View.GONE : View.VISIBLE}"
             app:cardBackgroundColor="@color/component_color_shared_revision_card_background_color"
@@ -120,14 +119,13 @@
 
           <com.google.android.material.card.MaterialCardView
             android:id="@+id/next_navigation_card"
-            android:layout_width="wrap_content"
+            android:layout_width="144dp"
             android:layout_height="wrap_content"
             android:layout_marginStart="28dp"
             android:layout_marginTop="16dp"
             android:layout_marginEnd="28dp"
             android:layout_marginBottom="@dimen/topic_revision_summary_view_container_margin_bottom"
             android:clipToPadding="true"
-            android:maxWidth="144dp"
             android:onClick="@{() -> viewModel.onNextCardClicked()}"
             android:visibility="@{viewModel.subtopicId &lt; viewModel.subtopicListSize ? View.VISIBLE : View.GONE}"
             app:cardBackgroundColor="@color/component_color_shared_revision_card_background_color"