This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
refactor: remove generated thrift srcs from repo #758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levy5307
previously approved these changes
Feb 18, 2021
zhangyifan27
approved these changes
Feb 20, 2021
levy5307
approved these changes
Feb 20, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I find it's considerably hard to refactor the thrift stuff in rdsn, so I begin my refactoring on removing the thrift-generated files, so as to reduce the overall complexity.
Now the generated sources are placed under
builder/thrift-gen, aka${CMAKE_BINARY_DIR}/thrift-gen. They will be linked into the binary during compilation.This PR still keeps replication.thrift, fd.thrift, dsn.layer2.thrift in their original place. They will be resolved in later PR.
In my long-term plan, I will split the large file "replication.thrift" into several smaller files, in order to improve the modularity.
This in turn allows us to separate cpp-client as a standalone project. Because we need to decouple the thrift structs that are the dependency of cpp-client with those that are irrelevant (like backup and duplication).