This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
fix(http): fix parse path from message #663
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Nov 10, 2020
acelyc111
approved these changes
Nov 11, 2020
levy5307
reviewed
Nov 11, 2020
| real_args.emplace_back(std::move(arg)); | ||
| } | ||
| } | ||
| if (real_args.size() == 0) { |
There was a problem hiding this comment.
std::string path;
for (const auto &real_arg: real_rags) {
path += real_arg;
path += '/';
}
if (!path.empty()) {
ret.path = std::move(path.substr(value.size() - 1));
}
neverchanje
approved these changes
Nov 16, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #594, it simplified http path, but it left a problem. For example:
The http request sent to meta server to list all apps is like
ip:port/meta/apps, http server will add a tuple like<'meta/apps', 'apps_handler'>, when server receives a http request, it will parse path from request, and find the handler by path.In current implementation, the registered path is like
meta/apps, and the path parsed from request is/meta/apps, as a result, the handler can not be found.This pr fix this problem, the path parsed from request will be
meta/appsas the implementation before #594.