This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 59
feat(split): parent group update partition count #654
Merged
neverchanje
merged 5 commits into
XiaoMi:master
from
hycdong:replica_parent_update_partition_count
Nov 2, 2020
Merged
feat(split): parent group update partition count #654
neverchanje
merged 5 commits into
XiaoMi:master
from
hycdong:replica_parent_update_partition_count
Nov 2, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Oct 30, 2020
neverchanje
reviewed
Nov 2, 2020
neverchanje
previously approved these changes
Nov 2, 2020
levy5307
previously approved these changes
Nov 2, 2020
acelyc111
previously approved these changes
Nov 2, 2020
hycdong
dismissed stale reviews from acelyc111, levy5307, and neverchanje
via
November 2, 2020 07:44
dd81f3c
acelyc111
approved these changes
Nov 2, 2020
neverchanje
approved these changes
Nov 2, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simple partition split process
More partition split discussion in issue #69 and partition split design doc
This pr solves the part of ninth step of partition split, which is bold in process description.
What this pr solve
When primary parent registers child succeed, it will update its own partition_count, then broadcast this to secondary through group_check. Besides, this pull request also adds related unit test.