This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
feat(security): init sasl #599
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Aug 24, 2020
src/runtime/security/sasl_utils.cpp
Outdated
| return SASL_OK; | ||
| } | ||
|
|
||
| ddebug_f("sasl log info: log level = {}, message = {}", logger_level_to_string(level), msg); |
There was a problem hiding this comment.
All logs are in DEBUG level? I think it;s needed to convert level to related rdsn's log level.
There was a problem hiding this comment.
I have thought about this. But the log level in sasl is not a one-to-one correspondence log level in rdsn.
log level in rdsn:
typedef enum dsn_log_level_t {
LOG_LEVEL_INFORMATION,
LOG_LEVEL_DEBUG,
LOG_LEVEL_WARNING,
LOG_LEVEL_ERROR,
LOG_LEVEL_FATAL,
LOG_LEVEL_COUNT,
LOG_LEVEL_INVALID
} dsn_log_level_t;
log level in sasl:
define SASL_LOG_NONE 0 /* don't log anything */
#define SASL_LOG_ERR 1 /* log unusual errors (default) */
#define SASL_LOG_FAIL 2 /* log all authentication failures */
#define SASL_LOG_WARN 3 /* log non-fatal warnings */
#define SASL_LOG_NOTE 4 /* more verbose than LOG_WARN */
#define SASL_LOG_DEBUG 5 /* more verbose than LOG_NOTE */
#define SASL_LOG_TRACE 6 /* traces of internal protocols */
#define SASL_LOG_PASS 7 /* traces of internal protocols, including passwords */
There was a problem hiding this comment.
How about?
SASL_LOG_ERR -> LOG_LEVEL_ERROR
SASL_LOG_FAIL/SASL_LOG_WARN -> LOG_LEVEL_WARNING
SASL_LOG_NOTE -> LOG_LEVEL_INFORMATION
othres -> LOG_LEVEL_DEBUG
There was a problem hiding this comment.
SASL_LOG_ERR -> LOG_LEVEL_ERROR
SASL_LOG_FAIL/SASL_LOG_WARN -> LOG_LEVEL_WARNING
SASL_LOG_NOTE -> LOG_LEVEL_DEBUG
othres -> LOG_LEVEL_INFORMATION
hycdong
reviewed
Aug 24, 2020
acelyc111
reviewed
Aug 24, 2020
acelyc111
approved these changes
Aug 25, 2020
neverchanje
approved these changes
Aug 26, 2020
hycdong
approved these changes
Aug 26, 2020
levy5307
added
the
type/config-change
levy5307
added a commit
to levy5307/rdsn
that referenced
this pull request
Dec 21, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the config of enable_auth is true, we should init sasl.
[security] + sasl_plugin_path =