feat(dup): verify private log validity before starting to duplicate #315

neverchanje · 2019-09-17T10:18:23Z

Pseudocode:

func load_mutation_from_private_log() {
  verify_start_decree(start_decree);

  do_loading...
}

Before duplicating, we must ensure there are mutation logs available,
not being garbage collected.

src/dist/replication/lib/mutation_log.h

hycdong · 2019-09-19T08:15:34Z

src/dist/replication/lib/mutation_log.cpp

+            if (result == invalid_decree) {
+                result = it->second.max_decree;
+            } else {
+                result = std::min(result, it->second.max_decree);


得到的是log_file中最小的max_decree，这个是最大的已经gc的decree嘛？

it->second.max_decree 是上一个日志文件的最大 decree，相当于当前日志最小 decree - 1，这个设计的很 tricky。
最终就是遍历一下所有日志，找最小的

确实tricky，以后可以考虑把max_decree这个变量名改掉

feat(dup): verify private log validity for duplication

12330ab

neverchanje added the component/duplication label Sep 18, 2019

neverchanje requested review from acelyc111, hycdong and qinzuoyan September 18, 2019 03:07

Merge branch 'master' into dup-part

9d5dd04

qinzuoyan previously approved these changes Sep 19, 2019

View reviewed changes

Merge branch 'master' into dup-part

035ec48

hycdong reviewed Sep 19, 2019

View reviewed changes

neverchanje added 3 commits September 19, 2019 16:52

add comments

12c495a

add comments

59ab2f7

Merge branch 'dup-part' of github.com:neverchanje/rdsn into dup-part

ef787b9

neverchanje dismissed qinzuoyan’s stale review via ef787b9 September 19, 2019 09:29

hycdong approved these changes Sep 19, 2019

View reviewed changes

qinzuoyan approved these changes Sep 19, 2019

View reviewed changes

qinzuoyan merged commit b8c5adf into XiaoMi:master Sep 19, 2019

neverchanje deleted the dup-part branch September 19, 2019 12:36

weekly-digest bot mentioned this pull request Sep 22, 2019

Weekly Digest (15 September, 2019 - 22 September, 2019) #318

Closed

neverchanje mentioned this pull request Oct 25, 2019

Release 1.12.0 apache/incubator-pegasus#409

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(dup): verify private log validity before starting to duplicate #315

feat(dup): verify private log validity before starting to duplicate #315

neverchanje commented Sep 17, 2019 •

edited

Loading

hycdong Sep 19, 2019

neverchanje Sep 19, 2019 •

edited

Loading

hycdong Sep 19, 2019 •

edited

Loading

feat(dup): verify private log validity before starting to duplicate #315

feat(dup): verify private log validity before starting to duplicate #315

Conversation

neverchanje commented Sep 17, 2019 • edited Loading

hycdong Sep 19, 2019

Choose a reason for hiding this comment

neverchanje Sep 19, 2019 • edited Loading

Choose a reason for hiding this comment

hycdong Sep 19, 2019 • edited Loading

Choose a reason for hiding this comment

neverchanje commented Sep 17, 2019 •

edited

Loading

neverchanje Sep 19, 2019 •

edited

Loading

hycdong Sep 19, 2019 •

edited

Loading