split: parent replica create child replica

src/dist/replication/lib/replica_stub.cpp

@@ -2270,25 +2270,24 @@ std::string replica_stub::get_replica_dir(const char *app_type,
 {
     std::string gpid_str = fmt::format("{}.{}", id.to_string(), app_type);
     std::string replica_dir;
-    bool is_dir_confict = false;
+    bool is_dir_exist = false;
     for (const std::string &data_dir : _options.data_dirs) {
         std::string dir = utils::filesystem::path_combine(data_dir, gpid_str);
-        if (utils::filesystem::directory_exists(dir) && parent_dir == "") {
-            if (is_dir_confict) {
-                dassert(
-                    false, "replica dir conflict: %s <--> %s", dir.c_str(), replica_dir.c_str());
-            }
-            replica_dir = dir;
-            is_dir_confict = true;
-        }
-
         // if creating child replica during partition split, we should gurantee child replica and
         // parent replica share the same data dir
         // parent_dir = <dir>/<gpid>.<app_type>, check if parent_dir's <dir> is euqal to <data_dir>
-        if (parent_dir.substr(0, data_dir.size() + 1) == data_dir + "/") {
+        if (parent_dir != "" && parent_dir.substr(0, data_dir.size() + 1) == data_dir + "/") {
             replica_dir = dir;
             _fs_manager.add_replica(id, replica_dir);
-            break;
+            return replica_dir;
+        }
+        if (utils::filesystem::directory_exists(dir) && parent_dir == "") {
+            if (is_dir_exist) {
+                dassert(
+                    false, "replica dir conflict: %s <--> %s", dir.c_str(), replica_dir.c_str());
+            }
+            replica_dir = dir;
+            is_dir_exist = true;
         }
     }
     if (replica_dir.empty() && create_new) {