This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
replication: fix cold backup bug & config loading #267
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
July 9, 2019 17:44
1. cold backup will return err code instead of assert, when the block_provider is unknown 2. if duplication and idempotent write are enabled together, abort the process
vagetablechicken
requested review from
neverchanje,
acelyc111,
hycdong,
qinzuoyan and
foreverneverer
|
由于禁止duplication和non idempotent write同时打开，pegasus的配置和test还需要修改一下 |
qinzuoyan
previously approved these changes
Jul 10, 2019
qinzuoyan
approved these changes
Jul 10, 2019
|
pegasus的配置和test已经修改好了，这个pr可以合了 |
hycdong
approved these changes
Jul 10, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
block_provider is unknown
the process