This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
http: move http as a submodule of dist #266
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
requested review from
shengofsun,
acelyc111,
hycdong,
qinzuoyan and
foreverneverer
acelyc111
approved these changes
Jul 8, 2019
qinzuoyan
approved these changes
Jul 9, 2019
hycdong
approved these changes
Jul 9, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
According to our plan: #141,
httpshould be placed underdist/, since it behaves in client-server model.Besides, http is currently only used by meta-server and replica-server, it shouldn't be included in the core runtime of rDSN.