This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
use c++14 mode for compilation #257
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
added
the
area/installation
added 3 commits
May 25, 2019 12:53
neverchanje
requested review from
vagetablechicken,
acelyc111,
shengofsun,
hycdong and
qinzuoyan
acelyc111
approved these changes
May 27, 2019
qinzuoyan
approved these changes
May 28, 2019
neverchanje
pushed a commit
to neverchanje/rdsn
that referenced
this pull request
Jun 17, 2019
This reverts commit 89eb360.
qinzuoyan
pushed a commit
that referenced
this pull request
Jun 17, 2019
neverchanje
added
the
type/invalid
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
C++14 has many advantages over C++11, and now it's fully mature for nearly three years. Besides, there's no difficulty for our current codebase to move onto C++14. What we need to do is to upgrade our least compiler support to gcc-5 (suggested GCC-5.5).
The first benefit is that we are no longer suffering from the bug of
std::regexlib in gcc-4.9, so no need forboost::regexthen.New features introduced in C++14 can be found in https://www.wikiwand.com/en/C%2B%2B14, some by far are useful for us:
std::make_unique: will replacedsn::make_uniquedsn/utility/chrono_literals.h