This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
dup: add change_duplication_status on meta_server #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
requested review from
qinzuoyan,
acelyc111,
hycdong and
foreverneverer
hycdong
reviewed
May 5, 2019
src/dist/replication/meta_server/duplication/meta_duplication_service.cpp
Show resolved
Hide resolved
src/dist/replication/meta_server/duplication/meta_duplication_service.cpp
Show resolved
Hide resolved
hycdong
approved these changes
May 6, 2019
acelyc111
approved these changes
May 6, 2019
| std::string remote_cluster_name, | ||
| std::string meta_store_path) | ||
| : id(dupid), | ||
| app_id(appid), | ||
| remote(std::move(remote_cluster_name)), | ||
| store_path(std::move(meta_store_path)), | ||
| create_timestamp_ms(dsn_now_ms()) | ||
| create_timestamp_ms(create_now_ms) | ||
| { |
There was a problem hiding this comment.
这个地方对时间精确度要求高吗？create_now_ms的值应该是初始化赋值时候的时间值，并不是此时这条代码执行的时候值吧？
neverchanje
pushed a commit
that referenced
this pull request
Jun 28, 2019
# Conflicts: # src/dist/replication/meta_server/duplication/meta_duplication_service.cpp # src/dist/replication/meta_server/duplication/meta_duplication_service.h # src/dist/replication/meta_server/meta_service.cpp # src/dist/replication/test/meta_test/unit_test/meta_duplication_service_test.cpp
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.