This repository has been archived by the owner on Jun 23, 2022. It is now read-only.
http: support tcmalloc heap profiler and growth profiler #225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
requested review from
qinzuoyan,
shengofsun,
acelyc111,
hycdong,
vagetablechicken and
mentoswang
qinzuoyan
approved these changes
Mar 7, 2019
acelyc111
reviewed
Mar 7, 2019
| { | ||
| MallocExtension *malloc_ext = MallocExtension::instance(); | ||
| ddebug("received requests for growth profile"); | ||
| malloc_ext->GetHeapGrowthStacks(&resp.body); |
There was a problem hiding this comment.
为什么不直接 MallocExtension::instance()->GetHeapGrowthStacks(&resp.body) 呢?
There was a problem hiding this comment.
按照原来 brpc 的写法，他觉得 MallocExtension::instance() 可能会返回 null，所以就获取这个变量 check null 一下，但是 tcmalloc 函数注释里写了永远不会返回 null，我这里就没有 check。那为了与原来代码保持一致我就没再改动。
acelyc111
approved these changes
Mar 8, 2019
24 tasks
neverchanje
pushed a commit
that referenced
this pull request
Jun 14, 2019
19 tasks
neverchanje
pushed a commit
that referenced
this pull request
Jun 20, 2019
neverchanje
pushed a commit
that referenced
this pull request
Jun 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the codes are copied from brpc, and formatted according to our code style.