refactor

XiaoMi · Aug 19, 2020 · f4f1d5d · f4f1d5d
1 parent 8d584da
commit f4f1d5d
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 5 deletions.
diff --git a/src/runtime/security/init.cpp b/src/runtime/security/init.cpp
@@ -18,11 +18,12 @@
 #include "kinit_context.h"
 
 #include <dsn/dist/fmt_logging.h>
+#include <dsn/utility/flags.h>
 
 namespace dsn {
 namespace security {
-extern char *FLAGS_krb5_config;
-extern char *FLAGS_krb5_keytab;
+DSN_DECLARE_string(krb5_config);
+DSN_DECLARE_string(krb5_keytab);
 
 /***
  * set kerberos envs(for more details:

diff --git a/src/runtime/security/kinit_context.cpp b/src/runtime/security/kinit_context.cpp
@@ -101,6 +101,7 @@ class kinit_context
     // keytab file with absolute path
     krb5_keytab _keytab;
     // credential cache
+    // TODO(zlw): reuse ticket from ccache
     krb5_ccache _ccache;
     krb5_get_init_creds_opt *_opt = nullptr;
 
@@ -158,9 +159,7 @@ void kinit_context::init_krb5_ctx()
     static std::once_flag once;
     std::call_once(once, [&]() {
         int64_t err = krb5_init_context(&_krb5_context);
-        if (err != 0) {
-            dassert_f(false, "init kerberos context failed, with kerberos  error_code = {}", err);
-        }
+        dcheck_eq(err, 0);
     });
 }