This repository has been archived by the owner on May 10, 2022. It is now read-only.
fix: close session when unable to connect #81
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
December 17, 2019 15:58
foreverneverer
approved these changes
Dec 17, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In addition to being able to close a session when it's still connecting, in this PR we also make connection warmup (connect before sending RPC) only runs when the session is disconnected.
How does it work
To close the session when it's still connecting, we modified
ReplicaSession#closeSessionand callmarkSessionDisconnectafter identifying that it's CONNECTING. This is intended to fix the bug #80.To make connection warmup only runs when the session is disconnected, we wrapped
doConnectastryConnect, which checks if the session is disconnected. If not, it will do nothing.