Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

How do I delete a tax class? #576

Closed
gaazkam opened this issue Mar 7, 2021 · 1 comment
Closed

How do I delete a tax class? #576

gaazkam opened this issue Mar 7, 2021 · 1 comment
Labels
bug
Milestone
0.8.3

Comments

@gaazkam
Copy link

gaazkam commented Mar 7, 2021

WCObject.TaxClass.Delete accepts an int parameter, but the TaxClass class has no such field. Instead there is the string slug field.

As per https://woocommerce.github.io/woocommerce-rest-api-docs/?shell#delete-a-tax-class in order to delete a tax class we need to specify a slug, which is a string, and not an int.
@XiaoFaye XiaoFaye added the bug label Mar 10, 2021
@XiaoFaye XiaoFaye added this to the 0.8.3 milestone Mar 10, 2021
XiaoFaye added a commit that referenced this issue Mar 10, 2021
@XiaoFaye
Add extension method DeleteTaxClass for deleting TaxClass. #576
04a1374
@XiaoFaye
Copy link
Owner

Hi, this is fixed in version 0.8.3.

@dependabot dependabot bot mentioned this issue Mar 18, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
0.8.3
Development

No branches or pull requests
2 participants
@XiaoFaye @gaazkam