Install root dependencies #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (err && err.code === 'ENOENT') return done(); | ||
| if (err) return done(err); | ||
|
|
||
| FS.copy(source, destination, done); |
There was a problem hiding this comment.
Should this be called copy-dependencies.js instead? 🙃
|
I fixed the build issues and resolved the conflict with |
theworkflow
force-pushed
the
feature/install-root-dependencies
branch
from
2e29f90 to
6fa8771
Compare
Remove unnecessary semicolons so the build passes. I broke it so I figured I would fix it. <3
theworkflow
force-pushed
the
feature/install-root-dependencies
branch
from
6fa8771 to
bb09432
Compare
|
Merge conflicts have been resolved. |
|
@theworkflow Are you considering closing #243 with this PR? |
fiveisprime
approved these changes
Nov 7, 2016
|
@jackboberg Not initially. I had the thought process that each function/file is an individual task. Updating the |
jackboberg
approved these changes
Nov 7, 2016
There was a problem hiding this comment.
A separate PR seems fine, I think it could be a part of find-node-version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Install root dependencies when
package.jsonis present. Then moves them to thedemeteorizedbundle.Closes #181