Add json-file option to choose a file to be merged with package.json #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| .parse(process.argv); | ||
|
|
||
| console.log('Demeteorizing application...'); | ||
|
|
||
| Program.output = Program.output || Path.join(process.cwd(), '.demeteorized'); | ||
|
|
||
| if(Program.jsonFile) { |
There was a problem hiding this comment.
nitpick: can you amend to add a space after the if to match style :)
|
This seems sensible, I'll test locally... |
|
@desjoerd thanks for the PR! Can you add some tests? |
|
@HarlanJ there is currently no test coverage for That said, if you want to do the legwork 💯 |
| @@ -22,11 +23,19 @@ Program | |||
| .option( | |||
| '-j, --json <json>', | |||
| 'JSON data to be merged into the generated package.json') | |||
| .option( | |||
| '-J, --json-file <jsonFile>' | |||
|
Sorry about the late comment! I will take a look how I can add some tests. I see two options:
I think option 1 is the best option. What do you guys think? |
|
@desjoerd sorry for being so late on this. Can you fix the merge conflict so we can look this over again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I needed the option to choose a file instead of using "cat" to include the package.json to be merged. This is because I need to use CMD or Powershell which doesn't have "cat" with the same escaping as bash.
I hope that this change will be merged.