Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update createbrandingthemepaymentservices method and bump version #524

Merged
merged 3 commits into from
Nov 16, 2022

Conversation

RettBehrens
Copy link
Contributor

@RettBehrens RettBehrens commented Nov 16, 2022

Description

Updates CreateBrandingThemePaymentServices method to accept an array of PaymentService objects instead of just one PaymentService object to match API functionality

Release Notes

Resolves Xero-Node #605

This will result in a small breaking change where any projects currently using this method will need to wrap their PaymentService object in a PaymentServices object like so:

{ "PaymentServices": [ { "PaymentServiceID": "54b3b4f6-0443-4fba-bcd1-61ec0c35ca55", "PaymentServiceName": "PayUpNow", "PaymentServiceUrl": "https://www.payupnow.com/", "PaymentServiceType": "Custom", "PayNowText": "Time To Pay" } ] }

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

@RettBehrens RettBehrens self-assigned this Nov 16, 2022
@RettBehrens RettBehrens merged commit 4608993 into master Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateBrandingThemePaymentServices should expect an array of payment services, not a single payment service
1 participant