Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generated SDK from Open API version 2.33.0 #452

Merged
merged 4 commits into from
Dec 1, 2022

Conversation

JRising-Xero
Copy link
Contributor

@JRising-Xero JRising-Xero commented Nov 20, 2022

Generates Xero-NetStandard 3.30.0 from Xero-OpenAPI 2.33.0

Accounting API

  • Updates CreateBrandingThemePaymentServices method to accept an array of PaymentService objects instead of just one PaymentService object to match API functionality
  • Adds 2023 tax rates for Singapore

Resolves Xero Node #605

  • This will result in a breaking change where any projects currently using this method will need to wrap their PaymentService object in a PaymentServices object like so:
{
   "PaymentServices":[
      {
         "PaymentServiceID":"54b3b4f6-0443-4fba-bcd1-61ec0c35ca55",
         "PaymentServiceName":"PayUpNow",
         "PaymentServiceUrl":"https://www.payupnow.com/",
         "PaymentServiceType":"Custom",
         "PayNowText":"Time To Pay"
      }
   ]
}
  • Updated data type of IsReconciled property of BatchPayment to boolean.
  • Updated data type of TotalAmount property of BatchPayment to decimal
    Related to this issue

Types of Changes

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Copy link
Contributor

@RettBehrens RettBehrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @JRising-Xero please regenerate to include the latest from OAS 2.33.1 and then you should be set to merge and release

@JRising-Xero JRising-Xero dismissed RettBehrens’s stale review December 1, 2022 01:39

Changes added in later commits.

@JRising-Xero JRising-Xero merged commit 2d7a8ee into master Dec 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateBrandingThemePaymentServices should expect an array of payment services, not a single payment service
3 participants