Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update sdk to OAS version 33 #326

Merged
merged 2 commits into from
Dec 5, 2022
Merged

Conversation

rdemarco-xero
Copy link
Contributor

Description

Accounting API

  • Updates CreateBrandingThemePaymentServices method to accept an array of PaymentService objects instead of just one PaymentService object to match API functionality
  • Adds 2023 tax rates for Singapore

Release Notes

Resolves Xero-Node #605

This will result in a small breaking change where any projects currently using this method will need to wrap their PaymentService object in a PaymentServices object like so:

{ "PaymentServices": [ { "PaymentServiceID": "54b3b4f6-0443-4fba-bcd1-61ec0c35ca55", "PaymentServiceName": "PayUpNow", "PaymentServiceUrl": "https://www.payupnow.com/", "PaymentServiceType": "Custom", "PayNowText": "Time To Pay" } ] }

Copy link
Contributor

@RettBehrens RettBehrens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @rdemarco-xero please regenerate from OAS 2.33.1 before releasing these updates, thanks!

@rdemarco-xero rdemarco-xero marked this pull request as ready for review December 5, 2022 17:39
@rdemarco-xero rdemarco-xero merged commit abc7dec into master Dec 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CreateBrandingThemePaymentServices should expect an array of payment services, not a single payment service
2 participants