Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default value on unique_suffix in core module #776

Merged
merged 3 commits into from
Sep 2, 2022

Conversation

NissesSenap
Copy link
Contributor

It's really easy to make configuration mistakes thanks to this default value.
For people not defining it you will need to set

unique_suffix = ""

Copy link
Contributor

@jimgus jimgus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very good!

@NissesSenap NissesSenap merged commit 3f73cab into main Sep 2, 2022
@NissesSenap NissesSenap deleted the default_value branch September 2, 2022 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants