Merge pull request #6 from stratoula/fix-vis-editors-failures

Solve TS problems in kibana-vis-editors files
XavierM · Sep 1, 2021 · d4bc9e0 · d4bc9e0
2 parents a6c8e07 + b882621
commit d4bc9e0
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/plugins/kibana_legacy/public/angular/angular_config.tsx b/src/plugins/kibana_legacy/public/angular/angular_config.tsx
@@ -76,7 +76,7 @@ export const configureAppAngularModule = (
   isLocalAngular: boolean,
   getHistory?: () => History
 ) => {
-  const core = 'core' in newPlatform ? newPlatform.core : newPlatform;
+  const core = ('core' in newPlatform ? newPlatform.core : newPlatform) as CoreStart;
   const packageInfo = newPlatform.env.packageInfo;
 
   angularModule

diff --git a/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts b/x-pack/plugins/lens/public/indexpattern_datasource/operations/definitions/index.ts
@@ -346,6 +346,7 @@ interface FieldlessOperationDefinition<C extends BaseIndexPatternColumn> {
     arg: BaseBuildColumnArgs & {
       previousColumn?: IndexPatternColumn;
     },
+    // @ts-ignore, TS not able to dig into this depth, https://github.com/elastic/kibana/issues/110761
     columnParams?: (IndexPatternColumn & C)['params']
   ) => C;
   /**
@@ -387,6 +388,7 @@ interface FieldBasedOperationDefinition<C extends BaseIndexPatternColumn> {
       field: IndexPatternField;
       previousColumn?: IndexPatternColumn;
     },
+    // @ts-ignore, TS not able to dig into this depth, https://github.com/elastic/kibana/issues/110761
     columnParams?: (IndexPatternColumn & C)['params'] & {
       kql?: string;
       lucene?: string;