Convert value provided to PhraseValueInput to string to catch Excepti…

…on (elastic#45259) (elastic#45365)
XavierM · Sep 11, 2019 · 8a535cf · 8a535cf
1 parent f4b1684
commit 8a535cf
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/src/legacy/core_plugins/data/public/filter/filter_bar/filter_editor/phrase_value_input.tsx b/src/legacy/core_plugins/data/public/filter/filter_bar/filter_editor/phrase_value_input.tsx
@@ -60,7 +60,9 @@ class PhraseValueInputUI extends PhraseSuggestor<Props> {
   private renderWithSuggestions() {
     const { suggestions } = this.state;
     const { value, intl, onChange } = this.props;
-    const options = value ? uniq([value, ...suggestions]) : suggestions;
+    // there are cases when the value is a number, this would cause an exception
+    const valueAsStr = String(value);
+    const options = value ? uniq([valueAsStr, ...suggestions]) : suggestions;
     return (
       <StringComboBox
         placeholder={intl.formatMessage({
@@ -69,7 +71,7 @@ class PhraseValueInputUI extends PhraseSuggestor<Props> {
         })}
         options={options}
         getLabel={option => option}
-        selectedOptions={value ? [value] : []}
+        selectedOptions={value ? [valueAsStr] : []}
         onChange={([newValue = '']) => onChange(newValue)}
         onSearchChange={this.onSearchChange}
         singleSelection={{ asPlainText: true }}