Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: ♻️ storybook with csf3 #2

Merged

Conversation

lloydrichards
Copy link

I got storybook running smoothly using the @storybook/nextjs framework instead of vite. This way there are less dependancies and the /.storybook/main.ts is a little cleaner.

With Storybook v7, how you were using the @storybook/addon-docs in mdx isn't the recommended way from storybook anymore. instead they prefer to use the new CSF3 format in .stories.ts files. These are also less likely to conflict with other MDX compilers like contentlayer which is used in the app/www.

For the time being i've just converted the .stories.mdx to .stories.tsx and not made too many changes (just some arg spreading), but will probably have a look and see if the structure can be improved or if things can be made a little more generic

@XavierGeerinck XavierGeerinck merged commit 9f5d957 into XavierGeerinck:main Jul 12, 2023
@lloydrichards lloydrichards deleted the refactor/storybook_with_CSF3 branch July 13, 2023 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants