Fix empty city generation

Xaritscin · Apr 18, 2022 · 6a10c8a · 6a10c8a
1 parent 735385b
commit 6a10c8a
Showing 1 changed file with 9 additions and 6 deletions.
diff --git a/src/overmap.cpp b/src/overmap.cpp
@@ -4971,17 +4971,20 @@ void overmap::place_cities()
                 tmp.size = size;
             }
         } else {
+            placement_attempts = 0;
             tmp = random_entry( cities_to_place );
             p = tripoint_om_omt( tmp.pos, 0 );
             ter_set( tripoint_om_omt( tmp.pos, 0 ), oter_road_nesw );
         }
-        cities.push_back( tmp );
-        const om_direction::type start_dir = om_direction::random();
-        om_direction::type cur_dir = start_dir;
+        if( placement_attempts == 0 ) {
+            cities.push_back( tmp );
+            const om_direction::type start_dir = om_direction::random();
+            om_direction::type cur_dir = start_dir;
 
-        do {
-            build_city_street( local_road, tmp.pos, tmp.size, cur_dir, tmp );
-        } while( ( cur_dir = om_direction::turn_right( cur_dir ) ) != start_dir );
+            do {
+                build_city_street( local_road, tmp.pos, tmp.size, cur_dir, tmp );
+            } while( ( cur_dir = om_direction::turn_right( cur_dir ) ) != start_dir );
+        }
     }
 }