Update to currently supported Target Frameworks. #2331
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This drops support for end-of-life TFMs: anything before `net8.0` keeping `netstandard2.0` in any library that supported it before. Tests are run on net8 and net9.
eerhardt
requested review from
unaizorrilla,
adamsitnik,
sungam3r and
Alirexaa
This already happens in the root test Directory.Build.props file.
…t9 tests can't run in parallel. Also remove version from docker-compose, since it is obsolete.
Alirexaa
reviewed
Dec 4, 2024
adamsitnik
approved these changes
Dec 4, 2024
test/HealthChecks.Elasticsearch.Tests/HealthChecks.Elasticsearch.Tests.csproj
Show resolved
Hide resolved
Alirexaa
approved these changes
Dec 4, 2024
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2331 +/- ##
==========================================
+ Coverage 64.25% 66.88% +2.62%
==========================================
Files 248 268 +20
Lines 8399 8730 +331
Branches 590 631 +41
==========================================
+ Hits 5397 5839 +442
+ Misses 2853 2723 -130
- Partials 149 168 +19
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This drops support for end-of-life TFMs: anything before
net8.0keepingnetstandard2.0in any library that supported it before.Tests are run on net8 and net9.
Does this PR introduce a user-facing change?:
Yes, it drops support for end-of-life TFMs in preparation for releasing the next major version.
Please make sure you've completed the relevant tasks for this PR, out of the following list: