-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove vulnerable dependencies #2327
Conversation
…severity vulnerability
….Azure.DocumentDB.Core package, fixes Xabaril#2325
…l health checks, move the version to one place so it's easier to update in the future
…severity vulnerability
…erate severity vulnerability Package 'System.IdentityModel.Tokens.Jwt' 7.0.0 has a known moderate severity vulnerability Major version update was required, as there is no 12.* version that does not have these deps
…verity vulnerability
… lot of old packages with vulns
…ity vulnerability
The support approach we are taking in .NET Aspire and with the libraries in dotnet/extensions is to use "tip support": https://dotnet.microsoft.com/en-us/platform/support/policy/aspire
So even if someone is on .NET 8 (LTS), they would use .NET Aspire 9, which supports .NET 8. We could follow a similar concept here and ship HealthChecks version 9, and support .NET 8. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
# Conflicts: # src/HealthChecks.ApplicationStatus/HealthChecks.ApplicationStatus.csproj # src/HealthChecks.ArangoDb/HealthChecks.ArangoDb.csproj # src/HealthChecks.Aws.S3/HealthChecks.Aws.S3.csproj # src/HealthChecks.Aws.SecretsManager/HealthChecks.Aws.SecretsManager.csproj # src/HealthChecks.Aws.Sns/HealthChecks.Aws.Sns.csproj # src/HealthChecks.Aws.Sqs/HealthChecks.Aws.Sqs.csproj # src/HealthChecks.Aws.SystemsManager/HealthChecks.Aws.SystemsManager.csproj # src/HealthChecks.Azure.Data.Tables/HealthChecks.Azure.Data.Tables.csproj # src/HealthChecks.Azure.IoTHub/HealthChecks.Azure.IoTHub.csproj # src/HealthChecks.Azure.KeyVault.Secrets/HealthChecks.Azure.KeyVault.Secrets.csproj # src/HealthChecks.Azure.Messaging.EventHubs/HealthChecks.Azure.Messaging.EventHubs.csproj # src/HealthChecks.Azure.Storage.Blobs/HealthChecks.Azure.Storage.Blobs.csproj # src/HealthChecks.Azure.Storage.Files.Shares/HealthChecks.Azure.Storage.Files.Shares.csproj # src/HealthChecks.Azure.Storage.Queues/HealthChecks.Azure.Storage.Queues.csproj # src/HealthChecks.AzureApplicationInsights/HealthChecks.AzureApplicationInsights.csproj # src/HealthChecks.AzureDigitalTwin/HealthChecks.AzureDigitalTwin.csproj # src/HealthChecks.AzureKeyVault/HealthChecks.AzureKeyVault.csproj # src/HealthChecks.AzureSearch/HealthChecks.AzureSearch.csproj # src/HealthChecks.AzureServiceBus/HealthChecks.AzureServiceBus.csproj # src/HealthChecks.Consul/HealthChecks.Consul.csproj # src/HealthChecks.CosmosDb/HealthChecks.CosmosDb.csproj # src/HealthChecks.Dapr/HealthChecks.Dapr.csproj # src/HealthChecks.DocumentDb/HealthChecks.DocumentDb.csproj # src/HealthChecks.DynamoDb/HealthChecks.DynamoDb.csproj # src/HealthChecks.Elasticsearch/HealthChecks.Elasticsearch.csproj # src/HealthChecks.EventStore.gRPC/HealthChecks.EventStore.gRPC.csproj # src/HealthChecks.EventStore/HealthChecks.EventStore.csproj # src/HealthChecks.Gcp.CloudFirestore/HealthChecks.Gcp.CloudFirestore.csproj # src/HealthChecks.Gremlin/HealthChecks.Gremlin.csproj # src/HealthChecks.Hangfire/HealthChecks.Hangfire.csproj # src/HealthChecks.IbmMQ/HealthChecks.IbmMQ.csproj # src/HealthChecks.InfluxDB/HealthChecks.InfluxDB.csproj # src/HealthChecks.Kafka/HealthChecks.Kafka.csproj # src/HealthChecks.Kubernetes/HealthChecks.Kubernetes.csproj # src/HealthChecks.Milvus/HealthChecks.Milvus.csproj # src/HealthChecks.MongoDb/HealthChecks.MongoDb.csproj # src/HealthChecks.MySql/HealthChecks.MySql.csproj # src/HealthChecks.Nats/HealthChecks.Nats.csproj # src/HealthChecks.Network/HealthChecks.Network.csproj # src/HealthChecks.NpgSql/HealthChecks.NpgSql.csproj # src/HealthChecks.OpenIdConnectServer/HealthChecks.OpenIdConnectServer.csproj # src/HealthChecks.Oracle/HealthChecks.Oracle.csproj # src/HealthChecks.Publisher.ApplicationInsights/HealthChecks.Publisher.ApplicationInsights.csproj # src/HealthChecks.Publisher.CloudWatch/HealthChecks.Publisher.CloudWatch.csproj # src/HealthChecks.Publisher.Datadog/HealthChecks.Publisher.Datadog.csproj # src/HealthChecks.Publisher.Prometheus/HealthChecks.Publisher.Prometheus.csproj # src/HealthChecks.Publisher.Seq/HealthChecks.Publisher.Seq.csproj # src/HealthChecks.Rabbitmq/HealthChecks.Rabbitmq.csproj # src/HealthChecks.RavenDB/HealthChecks.RavenDB.csproj # src/HealthChecks.Redis/HealthChecks.Redis.csproj # src/HealthChecks.SendGrid/HealthChecks.SendGrid.csproj # src/HealthChecks.SignalR/HealthChecks.SignalR.csproj # src/HealthChecks.Solr/HealthChecks.Solr.csproj # src/HealthChecks.SqlServer/HealthChecks.SqlServer.csproj # src/HealthChecks.Sqlite/HealthChecks.Sqlite.csproj # src/HealthChecks.System/HealthChecks.System.csproj # src/HealthChecks.UI.Client/HealthChecks.UI.Client.csproj # src/HealthChecks.UI.Core/HealthChecks.UI.Core.csproj # src/HealthChecks.UI.InMemory.Storage/HealthChecks.UI.InMemory.Storage.csproj # src/HealthChecks.UI.PostgreSQL.Storage/HealthChecks.UI.PostgreSQL.Storage.csproj # src/HealthChecks.UI.SQLite.Storage/HealthChecks.UI.SQLite.Storage.csproj # src/HealthChecks.UI.SqlServer.Storage/HealthChecks.UI.SqlServer.Storage.csproj # src/HealthChecks.UI/HealthChecks.UI.csproj # src/HealthChecks.Uris/HealthChecks.Uris.csproj # test/Directory.Build.props # test/HealthChecks.UI.Data.Tests/HealthChecks.UI.Data.Tests.csproj
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #2327 +/- ##
==========================================
+ Coverage 64.25% 64.93% +0.67%
==========================================
Files 248 262 +14
Lines 8399 8633 +234
Branches 590 622 +32
==========================================
+ Hits 5397 5606 +209
- Misses 2853 2863 +10
- Partials 149 164 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
I wanted to start preparing for the 9.0 release and when I tried to build the repo I've run into few hundreds of warnings about vulnerable dependencies. I've fixed all of them.
Most of the changes are self-explanatory, for others I've added comments. This PR also includes a fix for #2325
@eerhardt I wonder if we should release a new 8.0.x version after this PR gets merged, before we ship the 9.0 version (.NET 8 is LTS so I expect plenty of people to still use it)