Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove vulnerable dependencies #2327

Merged
merged 24 commits into from
Dec 3, 2024
Merged

Conversation

adamsitnik
Copy link
Collaborator

I wanted to start preparing for the 9.0 release and when I tried to build the repo I've run into few hundreds of warnings about vulnerable dependencies. I've fixed all of them.

Most of the changes are self-explanatory, for others I've added comments. This PR also includes a fix for #2325

@eerhardt I wonder if we should release a new 8.0.x version after this PR gets merged, before we ship the 9.0 version (.NET 8 is LTS so I expect plenty of people to still use it)

…l health checks, move the version to one place so it's easier to update in the future
…erate severity vulnerability

Package 'System.IdentityModel.Tokens.Jwt' 7.0.0 has a known moderate severity vulnerability

Major version update was required, as there is no 12.* version that does not have these deps
@eerhardt
Copy link
Collaborator

eerhardt commented Dec 3, 2024

I wonder if we should release a new 8.0.x version after this PR gets merged, before we ship the 9.0 version (.NET 8 is LTS so I expect plenty of people to still use it)

The support approach we are taking in .NET Aspire and with the libraries in dotnet/extensions is to use "tip support": https://dotnet.microsoft.com/en-us/platform/support/policy/aspire

At any time, only the latest release of .NET Aspire is supported by Microsoft. For example: support for .NET Aspire 8.0 ends when .NET Aspire 8.1 is released.

So even if someone is on .NET 8 (LTS), they would use .NET Aspire 9, which supports .NET 8.

We could follow a similar concept here and ship HealthChecks version 9, and support .NET 8.

Copy link
Collaborator

@eerhardt eerhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

# Conflicts:
#	src/HealthChecks.ApplicationStatus/HealthChecks.ApplicationStatus.csproj
#	src/HealthChecks.ArangoDb/HealthChecks.ArangoDb.csproj
#	src/HealthChecks.Aws.S3/HealthChecks.Aws.S3.csproj
#	src/HealthChecks.Aws.SecretsManager/HealthChecks.Aws.SecretsManager.csproj
#	src/HealthChecks.Aws.Sns/HealthChecks.Aws.Sns.csproj
#	src/HealthChecks.Aws.Sqs/HealthChecks.Aws.Sqs.csproj
#	src/HealthChecks.Aws.SystemsManager/HealthChecks.Aws.SystemsManager.csproj
#	src/HealthChecks.Azure.Data.Tables/HealthChecks.Azure.Data.Tables.csproj
#	src/HealthChecks.Azure.IoTHub/HealthChecks.Azure.IoTHub.csproj
#	src/HealthChecks.Azure.KeyVault.Secrets/HealthChecks.Azure.KeyVault.Secrets.csproj
#	src/HealthChecks.Azure.Messaging.EventHubs/HealthChecks.Azure.Messaging.EventHubs.csproj
#	src/HealthChecks.Azure.Storage.Blobs/HealthChecks.Azure.Storage.Blobs.csproj
#	src/HealthChecks.Azure.Storage.Files.Shares/HealthChecks.Azure.Storage.Files.Shares.csproj
#	src/HealthChecks.Azure.Storage.Queues/HealthChecks.Azure.Storage.Queues.csproj
#	src/HealthChecks.AzureApplicationInsights/HealthChecks.AzureApplicationInsights.csproj
#	src/HealthChecks.AzureDigitalTwin/HealthChecks.AzureDigitalTwin.csproj
#	src/HealthChecks.AzureKeyVault/HealthChecks.AzureKeyVault.csproj
#	src/HealthChecks.AzureSearch/HealthChecks.AzureSearch.csproj
#	src/HealthChecks.AzureServiceBus/HealthChecks.AzureServiceBus.csproj
#	src/HealthChecks.Consul/HealthChecks.Consul.csproj
#	src/HealthChecks.CosmosDb/HealthChecks.CosmosDb.csproj
#	src/HealthChecks.Dapr/HealthChecks.Dapr.csproj
#	src/HealthChecks.DocumentDb/HealthChecks.DocumentDb.csproj
#	src/HealthChecks.DynamoDb/HealthChecks.DynamoDb.csproj
#	src/HealthChecks.Elasticsearch/HealthChecks.Elasticsearch.csproj
#	src/HealthChecks.EventStore.gRPC/HealthChecks.EventStore.gRPC.csproj
#	src/HealthChecks.EventStore/HealthChecks.EventStore.csproj
#	src/HealthChecks.Gcp.CloudFirestore/HealthChecks.Gcp.CloudFirestore.csproj
#	src/HealthChecks.Gremlin/HealthChecks.Gremlin.csproj
#	src/HealthChecks.Hangfire/HealthChecks.Hangfire.csproj
#	src/HealthChecks.IbmMQ/HealthChecks.IbmMQ.csproj
#	src/HealthChecks.InfluxDB/HealthChecks.InfluxDB.csproj
#	src/HealthChecks.Kafka/HealthChecks.Kafka.csproj
#	src/HealthChecks.Kubernetes/HealthChecks.Kubernetes.csproj
#	src/HealthChecks.Milvus/HealthChecks.Milvus.csproj
#	src/HealthChecks.MongoDb/HealthChecks.MongoDb.csproj
#	src/HealthChecks.MySql/HealthChecks.MySql.csproj
#	src/HealthChecks.Nats/HealthChecks.Nats.csproj
#	src/HealthChecks.Network/HealthChecks.Network.csproj
#	src/HealthChecks.NpgSql/HealthChecks.NpgSql.csproj
#	src/HealthChecks.OpenIdConnectServer/HealthChecks.OpenIdConnectServer.csproj
#	src/HealthChecks.Oracle/HealthChecks.Oracle.csproj
#	src/HealthChecks.Publisher.ApplicationInsights/HealthChecks.Publisher.ApplicationInsights.csproj
#	src/HealthChecks.Publisher.CloudWatch/HealthChecks.Publisher.CloudWatch.csproj
#	src/HealthChecks.Publisher.Datadog/HealthChecks.Publisher.Datadog.csproj
#	src/HealthChecks.Publisher.Prometheus/HealthChecks.Publisher.Prometheus.csproj
#	src/HealthChecks.Publisher.Seq/HealthChecks.Publisher.Seq.csproj
#	src/HealthChecks.Rabbitmq/HealthChecks.Rabbitmq.csproj
#	src/HealthChecks.RavenDB/HealthChecks.RavenDB.csproj
#	src/HealthChecks.Redis/HealthChecks.Redis.csproj
#	src/HealthChecks.SendGrid/HealthChecks.SendGrid.csproj
#	src/HealthChecks.SignalR/HealthChecks.SignalR.csproj
#	src/HealthChecks.Solr/HealthChecks.Solr.csproj
#	src/HealthChecks.SqlServer/HealthChecks.SqlServer.csproj
#	src/HealthChecks.Sqlite/HealthChecks.Sqlite.csproj
#	src/HealthChecks.System/HealthChecks.System.csproj
#	src/HealthChecks.UI.Client/HealthChecks.UI.Client.csproj
#	src/HealthChecks.UI.Core/HealthChecks.UI.Core.csproj
#	src/HealthChecks.UI.InMemory.Storage/HealthChecks.UI.InMemory.Storage.csproj
#	src/HealthChecks.UI.PostgreSQL.Storage/HealthChecks.UI.PostgreSQL.Storage.csproj
#	src/HealthChecks.UI.SQLite.Storage/HealthChecks.UI.SQLite.Storage.csproj
#	src/HealthChecks.UI.SqlServer.Storage/HealthChecks.UI.SqlServer.Storage.csproj
#	src/HealthChecks.UI/HealthChecks.UI.csproj
#	src/HealthChecks.Uris/HealthChecks.Uris.csproj
#	test/Directory.Build.props
#	test/HealthChecks.UI.Data.Tests/HealthChecks.UI.Data.Tests.csproj
@adamsitnik adamsitnik merged commit 52bde8c into Xabaril:master Dec 3, 2024
59 checks passed
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.93%. Comparing base (4a49dfa) to head (64d260e).
Report is 40 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2327      +/-   ##
==========================================
+ Coverage   64.25%   64.93%   +0.67%     
==========================================
  Files         248      262      +14     
  Lines        8399     8633     +234     
  Branches      590      622      +32     
==========================================
+ Hits         5397     5606     +209     
- Misses       2853     2863      +10     
- Partials      149      164      +15     
Flag Coverage Δ
ApplicationStatus 28.67% <ø> (ø)
ArangoDb 28.30% <ø> (ø)
Aws.S3 15.52% <ø> (ø)
Aws.SecretsManager 15.82% <ø> (ø)
Aws.Sns 15.97% <ø> (ø)
Aws.Sqs 16.66% <ø> (ø)
Aws.SystemsManager 15.82% <ø> (ø)
Azure.IoTHub 13.82% <ø> (ø)
AzureApplicationInsights 16.56% <ø> (ø)
AzureBlobStorage 26.42% <ø> (?)
AzureDigitalTwin 37.15% <ø> (ø)
AzureEventHubs 17.46% <ø> (?)
AzureFileStorage 26.42% <ø> (?)
AzureKeyVault 30.48% <ø> (ø)
AzureQueueStorage 26.42% <ø> (?)
AzureSearch 17.60% <ø> (ø)
AzureServiceBus 72.48% <ø> (ø)
AzureTableStorage 27.97% <ø> (?)
Consul 24.32% <ø> (ø)
CosmosDb 29.45% <ø> (ø)
Dapr 14.50% <ø> (?)
DocumentDb ?
DynamoDb 13.29% <ø> (ø)
Elasticsearch 47.66% <ø> (+6.54%) ⬆️
EventStore 65.14% <ø> (ø)
EventStore.gRPC 25.51% <ø> (ø)
Gcp.CloudFirestore 13.33% <ø> (ø)
Gremlin 25.00% <ø> (ø)
Hangfire 12.10% <ø> (ø)
IbmMQ 30.76% <ø> (ø)
InfluxDB 15.54% <ø> (ø)
Kafka 23.52% <ø> (ø)
Kubernetes 41.54% <ø> (ø)
Milvus 16.78% <ø> (?)
MongoDb 32.85% <ø> (ø)
MySql 33.33% <ø> (ø)
Nats 72.77% <ø> (ø)
Npgsql 42.71% <ø> (ø)
OpenIdConnectServer 41.26% <ø> (ø)
Oracle 63.92% <ø> (ø)
Prometheus.Metrics ?
Publisher.ApplicationInsights 15.27% <ø> (ø)
Publisher.CloudWatch 20.33% <ø> (ø)
Publisher.Datadog 16.33% <ø> (ø)
Publisher.Prometheus 18.75% <ø> (ø)
Publisher.Seq 40.30% <ø> (ø)
Qdrant 18.25% <ø> (?)
RabbitMQ 50.63% <ø> (+1.07%) ⬆️
RavenDb 73.42% <ø> (ø)
Redis 68.47% <ø> (ø)
SendGrid 13.19% <ø> (ø)
SignalR 25.97% <ø> (ø)
SqlServer 30.43% <ø> (ø)
Sqlite 25.88% <ø> (-2.33%) ⬇️
System 43.58% <ø> (ø)
UI 65.94% <ø> (+0.25%) ⬆️
Uris 0.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@adamsitnik adamsitnik added this to the 9.0 milestone Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment