-
Notifications
You must be signed in to change notification settings - Fork 800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add CPM #2278
Add CPM #2278
Conversation
@adamsitnik, please take a look. |
I just had 2 comments. Everything else looks good to me. @adamsitnik @unaizorrilla - any concerns with this? |
Thanks for the review. |
src/HealthChecks.UI.K8s.Operator/HealthChecks.UI.K8s.Operator.csproj
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks!
@Alirexaa @unaizorrilla @sungam3r @adamsitnik - do you know of a timeline when HealthChecks 9.0 would be released? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thank you for your contribution @Alirexaa !
What this PR does / why we need it:
Which issue(s) this PR fixes:
Please reference the issue this PR will close: #2006
Special notes for your reviewer:
I changedhealthchecks_elasticsearch_ci.yml
andhealthchecks_kafka_ci.yml
to make ci green.Elasticsearch tests failed because of mariotoffia/FluentDocker#312 and actions/runner-images#9692.So I made a temporary fix based on mariotoffia/FluentDocker#312 (comment).Kafka ci failed because of deprecated images. I did update to new ones.Does this PR introduce a user-facing change?:
Please make sure you've completed the relevant tasks for this PR, out of the following list: