fix the build

Xabaril · Nov 29, 2024 · 8bdb819 · 8bdb819
1 parent 4791917
commit 8bdb819
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 8 deletions.
diff --git a/samples/HealthChecks.Sample/HealthChecks.Sample.csproj b/samples/HealthChecks.Sample/HealthChecks.Sample.csproj
@@ -13,7 +13,6 @@
   </ItemGroup>
 
   <ItemGroup>
-    <ProjectReference Include="..\..\src\HealthChecks.CosmosDb\HealthChecks.CosmosDb.csproj" />
     <ProjectReference Include="..\..\src\HealthChecks.OpenIdConnectServer\HealthChecks.OpenIdConnectServer.csproj" />
     <ProjectReference Include="..\..\src\HealthChecks.Prometheus.Metrics\HealthChecks.Prometheus.Metrics.csproj" />
     <ProjectReference Include="..\..\src\HealthChecks.Publisher.ApplicationInsights\HealthChecks.Publisher.ApplicationInsights.csproj" />

diff --git a/src/Directory.Build.props b/src/Directory.Build.props
@@ -34,7 +34,7 @@
     <InternalsVisibleTo Include="$(MSBuildProjectName).Tests" Condition="'$(SignAssembly)' != 'true'"/>
   </ItemGroup>
 
-  <ItemGroup Condition="!$(MSBuildProjectName.StartsWith('HealthChecks.UI'))">
+  <ItemGroup Condition="!$(MSBuildProjectName.StartsWith('HealthChecks.UI')) OR '$(MSBuildProjectName)' == 'HealthChecks.UI.Core'">
     <PackageReference Include="Microsoft.Extensions.Diagnostics.HealthChecks" Version="8.0.11" />
   </ItemGroup>
 

diff --git a/src/HealthChecks.CosmosDb/HealthChecks.CosmosDb.csproj b/src/HealthChecks.CosmosDb/HealthChecks.CosmosDb.csproj
@@ -5,6 +5,8 @@
     <PackageTags>$(PackageTags);Azure;CosmosDb</PackageTags>
     <Description>HealthChecks.CosmosDb is the health check package for Azure CosmosDb.</Description>
     <VersionPrefix>$(HealthCheckCosmosDb)</VersionPrefix>
+    <!-- Microsoft.Azure.Cosmos requires the app to install Newtonsoft.Json, we just disable that check here -->
+    <AzureCosmosDisableNewtonsoftJsonCheck>true</AzureCosmosDisableNewtonsoftJsonCheck>
   </PropertyGroup>
 
   <ItemGroup>

diff --git a/src/HealthChecks.UI.Core/HealthChecks.UI.Core.csproj b/src/HealthChecks.UI.Core/HealthChecks.UI.Core.csproj
@@ -7,8 +7,4 @@
     <VersionPrefix>$(HealthCheckUICore)</VersionPrefix>
   </PropertyGroup>
 
-  <ItemGroup>
-    <PackageReference Include="Microsoft.Extensions.DependencyInjection.Abstractions" Version="8.0.0" />
-  </ItemGroup>
-
 </Project>
diff --git a/test/HealthChecks.Sqlite.Tests/Functional/SqliteHealthCheckTests.cs b/test/HealthChecks.Sqlite.Tests/Functional/SqliteHealthCheckTests.cs
@@ -5,7 +5,7 @@ namespace HealthChecks.Sqlite.Tests.Functional;
 public class sqlite_healthcheck_should
 {
     [Fact]
-    public async void be_healthy_when_sqlite_is_available()
+    public async Task be_healthy_when_sqlite_is_available()
     {
         var webHostBuilder = new WebHostBuilder()
             .ConfigureServices(services =>
@@ -53,7 +53,7 @@ public async Task be_unhealthy_when_sqlite_is_unavailable()
     }
 
     [Fact]
-    public async void be_unhealthy_when_sqlquery_is_not_valid()
+    public async Task be_unhealthy_when_sqlquery_is_not_valid()
     {
         var webHostBuilder = new WebHostBuilder()
             .ConfigureServices(services =>