Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update isSigned null check to handle multi-signed transactions #2308

Merged
merged 6 commits into from
May 18, 2023
Merged

update isSigned null check to handle multi-signed transactions #2308

merged 6 commits into from
May 18, 2023

Conversation

khancode
Copy link
Collaborator

@khancode khancode commented May 5, 2023 •
edited
Loading

High Level Overview of Change

Update isSigned() null check to handle multi-signed transactions.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Refactor (non-breaking change that only restructures code)
  • Tests (You added tests for code that already exists, or your new feature included in this PR)
  • Documentation Updates
  • Release

Test Plan

Adds a unit test for verifying a multi-signed transaction is signed.

@khancode khancode requested review from intelliot, pdp2121 and mvadari May 5, 2023 21:57
@pdp2121 pdp2121 mentioned this pull request May 5, 2023
Merged
7 tasks
mvadari
mvadari approved these changes May 8, 2023
View reviewed changes
Copy link
Collaborator

@mvadari mvadari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but looks like browser tests are failing for a non-flaky reason

@khancode khancode changed the title update isSigned null check to use && update isSigned null check to handle a multi-signed transaction May 18, 2023
pdp2121
pdp2121 requested changes May 18, 2023
View reviewed changes
Copy link
Collaborator

@pdp2121 pdp2121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unit tests for normal & multisign cases needed

@khancode khancode changed the title update isSigned null check to handle a multi-signed transaction update isSigned null check to handle multi-signed transactions May 18, 2023
@khancode khancode requested review from ckniffen and pdp2121 May 18, 2023 22:35
@khancode khancode merged commit 97b2e66 into main May 18, 2023
@khancode khancode deleted the update-is-signed-null-check branch May 18, 2023 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@intelliot intelliot intelliot approved these changes

@ckniffen ckniffen ckniffen approved these changes

@justinr1234 justinr1234 justinr1234 approved these changes

@mvadari mvadari mvadari approved these changes

@pdp2121 pdp2121 pdp2121 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@khancode @intelliot @ckniffen @justinr1234 @mvadari @pdp2121